Node not found warnings #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoghanmurray
force-pushed
the
node-not-found-warnings
branch
2 times, most recently
from
df6be4f
to
25b1df9
Compare
|
I love this, this is going to save many breaking replays in the case of minor hiccups. It would be nice to see some tests around this though. I'm happy to help you out with them. |
…use some other mutation already removed it
…rong, e.g. node removal parent belongs to a different FullSnapshot and has e.g. a text nodeType
… - or the parent node for a removed node has been already removed
eoghanmurray
force-pushed
the
node-not-found-warnings
branch
from
25b1df9
to
853a51e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a try/catch around all mutations and show a warning rather than stopping playback because of the exception
Change how 'node not found' warnings are reported: