-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and tweaks #795
Fixes and tweaks #795
Conversation
Hi @Mark-Fenng ! Thanks for taking a look at the PR. Feel free to suggest any changes, I'm open :) |
@croqaz Thanks for your contribution. You may still have two little points to correct and finally, don't forget to rebase the latest master branch coz there are conflicts between them. |
Thank you for all the guidance @Mark-Fenng ! |
This PR is a short continuation of #770 , to add 2 log messages.
Also fix a non-obvious error, when
cssText = getCssRulesString(...)
crashes because stylesheet=null and snapshot function doesn't return. It happens sometimes: #764 (comment)Also removedCSSStyleSheet.rules
which is deprecated: https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleSheet#legacy_properties