Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and tweaks #795

Merged
merged 18 commits into from
Jan 28, 2022
Merged

Fixes and tweaks #795

merged 18 commits into from
Jan 28, 2022

Conversation

croqaz
Copy link
Contributor

@croqaz croqaz commented Jan 12, 2022

This PR is a short continuation of #770 , to add 2 log messages.
Also fix a non-obvious error, when cssText = getCssRulesString(...) crashes because stylesheet=null and snapshot function doesn't return. It happens sometimes: #764 (comment)
Also removed CSSStyleSheet.rules which is deprecated: https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleSheet#legacy_properties

packages/rrweb-snapshot/src/snapshot.ts Outdated Show resolved Hide resolved
packages/rrweb-snapshot/src/snapshot.ts Outdated Show resolved Hide resolved
@croqaz
Copy link
Contributor Author

croqaz commented Jan 25, 2022

Hi @Mark-Fenng ! Thanks for taking a look at the PR.
I noticed you fixed some issues with the inline image, but there's a try catch that I think can be improved a bit, so I hope you don't mind I moved it into the new function recordInlineImage that you have created: 4089127
I believe it doesn't make sense to try catch the function definition, so it should be merged.

Feel free to suggest any changes, I'm open :)

@YunFeng0817
Copy link
Member

@croqaz Thanks for your contribution. You may still have two little points to correct and finally, don't forget to rebase the latest master branch coz there are conflicts between them.

@croqaz
Copy link
Contributor Author

croqaz commented Jan 27, 2022

Thank you for all the guidance @Mark-Fenng !

@Yuyz0112 Yuyz0112 merged commit b0dc388 into rrweb-io:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants