Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Fix dnslink lookup #83

Closed
dvc94ch opened this issue Mar 9, 2020 · 3 comments
Closed

Fix dnslink lookup #83

dvc94ch opened this issue Mar 9, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@dvc94ch
Copy link
Contributor

dvc94ch commented Mar 9, 2020

Previously domain was used but that is tokio-0.1 library. Now domain seems to have upgraded to latest tokio in https://github.com/NLnetLabs/domain.

Our needs for the DNS are:

  • stub resolving
  • TXT records to get dnslink 1 2

rust-libp2p should already handle resolving names in /dns4 and /dns6 multiaddrs through threadpooled (stub?) resolver (haven't checked which library).

Being able to resolve dnslinks is the desired outcome. The async-std dependency seems a bit difficult. Alternatives on tokio would include trust-dns. Even if we decide to add back tokio support, we should be considering the what ever way libp2p is using as something we could leave for async-std.

@dvc94ch dvc94ch self-assigned this Mar 9, 2020
@aphelionz aphelionz added the bug Something isn't working label Apr 7, 2020
@koivunej koivunej changed the title fix dns lookup Fix dnslink lookup Jun 23, 2020
@koivunej koivunej mentioned this issue Jun 23, 2020
5 tasks
@koivunej
Copy link
Collaborator

koivunej commented Aug 10, 2020

I think this is now fixed with some of ljedrz latest dep update PRs.

@ljedrz
Copy link
Member

ljedrz commented Aug 10, 2020

Ah yeah, the related tests pass (when enabled with tokio) after cb0fa7b.

@koivunej
Copy link
Collaborator

And now we are fully tokio so this is always enabled.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants