Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the stdlib's context package #14

Closed
vrischmann opened this issue Jul 21, 2016 · 5 comments
Closed

use the stdlib's context package #14

vrischmann opened this issue Jul 21, 2016 · 5 comments

Comments

@vrischmann
Copy link

Hi,

any plan to use the stdlib's context after Go 1.7 is released ?

@rs
Copy link
Owner

rs commented Jul 27, 2016

I'm not sure it would be relevant. Why would you want to continue using xhandler once Go 1.7 is released?

@vrischmann
Copy link
Author

Right, we can now get the context on the request, but there's still the middlewares and xmux. But you're right, it doesn't make much sense to keep the API as is, so maybe it'd be best for me to start fresh and just take the middleware stuff.

@rs
Copy link
Owner

rs commented Jul 28, 2016

Xmux is httprouter with context support. You can now use httprouter directly.

I may split the middleware and the chain tool in a separate project if you think it would be interesting.

@vrischmann
Copy link
Author

To be honest I don't really know right now, I'll have to look at what I do. Looking at my usage of xhandler.Chain it's literally just calls to ch.Use and nothing else, so I may just c/p Chain in my own code, and use the std http.Handler + httprouter in the future.

Anyway I think we can close this issue, thanks for your responses :)

@rs
Copy link
Owner

rs commented Jul 28, 2016

Anytime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants