Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary alloc in MarshalJSON #50

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Avoid unnecessary alloc in MarshalJSON #50

merged 1 commit into from
Apr 29, 2019

Conversation

alcore
Copy link
Contributor

@alcore alcore commented Apr 28, 2019

As per title, 1 alloc within MarshalJSON can be avoided at the cost of a tiny bit of duplication.

benchmark                  old ns/op     new ns/op     delta
BenchmarkMarshalJSON-8     45.1          32.0          -29.05%

benchmark                  old allocs    new allocs    delta
BenchmarkMarshalJSON-8     2             1             -50.00%

benchmark                  old bytes     new bytes     delta
BenchmarkMarshalJSON-8     64            32            -50.00%

@alcore
Avoid unnecessary alloc in MarshalJSON()
d59a9cc 
Signed-off-by: Michał Chojnacki <m.chojnacki@muyo.io>
@rs rs merged commit ba6f703 into rs:master Apr 29, 2019
@narqo narqo mentioned this pull request Feb 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alcore @rs