Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect values for Data Type related SDO abort codes #7

Open
follower opened this issue Feb 4, 2019 · 0 comments
Open

Incorrect values for Data Type related SDO abort codes #7

follower opened this issue Feb 4, 2019 · 0 comments

Comments

@follower
Copy link

follower commented Feb 4, 2019

These SDO abort code values are incorrect as they have the prefix 0x0606 instead of 0x0607 (e.g. see):

{ 0x06060010, "Data type does not match, lengh of service parameter does not match"},
{ 0x06060012, "Data type does not match, lengh of service parameter is too high"},
{ 0x06060013, "Data type does not match, lengh of service parameter is too low"},

Presumably this is a copy/paste error.

Quick patch:

diff --git a/canopen/canopen.c b/canopen/canopen.c
index b02fdda..b2d2b7a 100644
--- a/canopen/canopen.c
+++ b/canopen/canopen.c
@@ -46,9 +46,9 @@ static SDO_abort_code_t SDO_abort_codes[] = {
     { 0x06040043, "General parameter incompatibility reason"},
     { 0x06040047, "General internal incompatibility in the device"},
     { 0x06060000, "Object access failed due to a hardware error"},
-    { 0x06060010, "Data type does not match, lengh of service parameter does not match"},
-    { 0x06060012, "Data type does not match, lengh of service parameter is too high"},
-    { 0x06060013, "Data type does not match, lengh of service parameter is too low"},
+    { 0x06070010, "Data type does not match, lengh of service parameter does not match"},
+    { 0x06070012, "Data type does not match, lengh of service parameter is too high"},
+    { 0x06070013, "Data type does not match, lengh of service parameter is too low"},
     { 0x06090011, "Sub-index does not exist"},
     { 0x06090030, "Value range of parameter exceeded (only for write access)"},
     { 0x06090031, "Value of parameter written too high"},

Note: "length" is also misspelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant