Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace check is too strict? #10

Closed
noherczeg opened this issue Feb 19, 2017 · 1 comment
Closed

Namespace check is too strict? #10

noherczeg opened this issue Feb 19, 2017 · 1 comment

Comments

@noherczeg
Copy link

The new UUID().parse(arguments[1]) phase only accepts your pre-defined few types. This is not documented if I'm not mistaken. Why has this logic been added since 1.1.x?

This UUID(3, "whatever", "value") used to work, now it fails.

@rse
Copy link
Owner

rse commented Feb 19, 2017

Well, what should happen for the namespace "whatever"? Unfortunately, it is not a valid UUID. That it worked in 1.1.x is just because JavaScript did not bail out with an error, although internally an incorrect conversion was done. Please change your new UUID(3, "whatever", "value") to e.g. `new UUID(3, new UUID(3, "ns:URL", "info:hdl/example.com/whatever"), "value") if you want to be compliant to the UUID standards and make it working with PureUUID again.

@rse rse closed this as completed Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants