Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Handler/PendingHandler #121

Closed
khionu opened this issue Dec 5, 2019 · 1 comment · Fixed by #129
Closed

Consolidate Handler/PendingHandler #121

khionu opened this issue Dec 5, 2019 · 1 comment · Fixed by #129
Labels
bug Something isn't working

Comments

@khionu
Copy link
Contributor

khionu commented Dec 5, 2019

Current concerns:

  • Panic handling is currently not done during poll
  • The flow, from start to finish of a message processing, is currently distributed in a way that makes it hard to keep changes in sync
  • As an async operation, each iteration of the ActorStream can and should have everything related to the pending outcome wrapped in a single Future.
@khionu khionu added the bug Something isn't working label Dec 5, 2019
@khionu
Copy link
Contributor Author

khionu commented Dec 17, 2019

After further reflection, there really isn't a lot that can be done about this. We can make sure the Handler has all the panic handling inside it, but other than that, consolidation would create more problems than it would solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant