feat: connect faucets component #139

lucachaco · 2022-02-02T03:39:50Z

Moving most of the logic into the faucet component
RBTC balance added

jessgusclark · 2022-02-02T10:09:17Z

src/screens/home/index.tsx

+      setRifToken(
+        balances.find(token => {
+          return token.symbol === 'tRIF'
+        }),
+      )
+      setRbtcToken(
+        balances.find(token => {
+          return token.symbol === 'TRBTC'
+        }),
+      )


Your code works well, but for better readability, it could be written like this:

setRifToken(balances.find(token => token.symbol === 'tRIF')) setRbtcToken(balances.find(token => token.symbol === 'TRBTC'))

Since you are only returning a single line, you can omit the { and return.

jessgusclark

Code is fine, however since the RBTC balance isn't loading it is hard to fully test.

One quick comment about code style.

ilanolkies

Should we add the RBTC balance to the global state in some way? We can add this together with the ticket to show back the RBTC in the portfolio

lucachaco · 2022-02-03T15:01:22Z

Hmm it is in the global state now with this and it shown in the portfolio

jessgusclark

Just one quick change on the rBTC balance and then some cleanup.

jessgusclark · 2022-02-03T15:28:53Z

src/screens/home/index.tsx


  const [selected, setSelected] = useState<ITokenWithBalance | null>(null)

  const [selectedPanel, setSelectedPanel] = useState<string>('portfolio')

+  const loadRBTCBalance = async () => {
+    const rbtcBalanceEntry = await wallet.provider!.getBalance(
+      wallet.smartWallet.address,


I think we need to get the RBTC balance of the EOA wallet not the smartwallet.

jessgusclark · 2022-02-03T15:30:14Z

src/screens/home/index.tsx

    if (!selected) {
      setSelected(balances[0])
    }
-  }, [balances])
+
+    loadRBTCBalance().then(() => console.log('RTBC loaded'))


Remove the console.log please.

jessgusclark · 2022-02-03T15:30:27Z

src/screens/home/index.tsx


  const selectedTokenColor = getTokenColor(selected?.symbol)

  const containerStyles = {
    shadowColor: setOpacity(selectedTokenColor, 0.5),
  }
+  //


remove this please.

ilanolkies

Sorry, the comment before was mistaken. I didn't see it added RBTC back. Great job!

We then need to work on some refactor. Home screen should not be responsible of subscribing to RBTC balance, we should work that in Core

ilanolkies · 2022-02-03T15:22:25Z

src/screens/home/index.tsx

-  }, [balances])
+
+    loadRBTCBalance().then(() => console.log('RTBC loaded'))
+  }, [state.balances])


This is doing an infinite loop because loadRBTCBalance changes state.balances. We can do polling with setInterval

ilanolkies · 2022-02-03T15:23:47Z

src/screens/home/index.tsx


  const [selected, setSelected] = useState<ITokenWithBalance | null>(null)

  const [selectedPanel, setSelectedPanel] = useState<string>('portfolio')

+  const loadRBTCBalance = async () => {
+    const rbtcBalanceEntry = await wallet.provider!.getBalance(


Open discussion, should we do this in the backend?

That might be a good idea since that way the service could easily be used for other apps, such as a browser wallet, or perhaps the rBench or Identity Manager. With one call you can get everything from the service.

jessgusclark

I see the rBTC balance, however, the balance is incorrect. We are missing a decimal:

explorer

ilanolkies

LGTM

ilanolkies · 2022-02-07T12:55:48Z

src/screens/home/index.tsx

  useEffect(() => {
+    const balances = Object.values(state.balances)
+
    if (!selected) {
      setSelected(balances[0])
    }
-  }, [balances])
+  }, [state.balances])


What is this used for?

ilanolkies · 2022-02-07T12:56:30Z

src/screens/home/index.tsx

+  useEffect(() => {
+    setInterval(async () => {
+      console.log('Loading RBTC')
+      loadRBTCBalance().then()
+    }, 5000)
+  }, [])


I would move this to another part of the code. Maybe in Core or in subscriptions.

ilanolkies

I tried moving the effect, is working fine. Still the RBTC faucet appears for a while before the RBTC balance has loaded.

For a new wallet:

Screen.Recording.2022-02-08.at.11.33.28.mov

For a wallet that has some other balances:

Screen.Recording.2022-02-08.at.12.11.16.mov

We can keep it this way now but we need to find a better solutions for loading states

ilanolkies · 2022-02-08T14:33:02Z

src/subscriptions/RIFSockets.tsx

    if (isWalletDeployed || isDeployed) {
      const connect = async () => {
        rifServiceSocket?.on('init', result => {
+          interval = setInterval(async () => {


This could start even if rifServiceSocket didn't init. I would do it in a different effect

React.useEffect(() => { const interval = setInterval(async () => { loadRBTCBalance(wallet, dispatch) }, 5000) return () => clearInterval(interval) }, [wallet])

ilanolkies

LGTM! Fixing the thing of the balance decimals. The balancetoString is working wrong

ilanolkies · 2022-02-08T23:58:26Z

* Section component to render options in settings * Implementing sections * Adding translate to section titles * Adding props to setting screen * Passing deleteKeys function down to the settings screen * removing delete keys button * Adding condition in case the key doesnt exist in the send screen and also deleting the deletekeys button from keysinfo screen * Fixing test * Allow the user to add new accounts and switch to them (#144) * Add screen for managing current wallet. * Pass addNewWallet to manage wallets screen. * Allow the user to switch the selectedWallet in the core. * Show addresses in manage screen. * In sockets file, move connect() feature outside of the useEffect. * combine functions into single useEffect and remove check for if wallet is deployed. * Remove unused variables, add sockets method and use it. * Add wallet and isDeployed to the list when clicking the button. * Clean up addWallet code. * Move next wallet creation to the operations file. * Pass networkId * Skipping these tests, see PR description. * Export props and use in RootNavigation * Enhancemnt/no usd value (#146) * Adding not available message to the balance row component * Linting * Simplifying quota prop * Update src/screens/home/BalanceRowComponent.tsx * Make USD text smaller Co-authored-by: Agustin Villalobos <agustin.villalobos@iovlabs.org> Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com> Co-authored-by: Ilan <ilanolkies@outlook.com> * feat: connect faucets component (#139) * feat: connect faucets component * chore: add comment * feat: add rbtc balance * feat: add rbtc balance * fix: refactor test * chore: remove console * fix: validate balances * format: lint code * fix: load rbtc balance with serInterval * fix: move rbtc load code * format: lint code * fix: move code * fix: remove duplicated line * fix: add missing types * fix: add todo comment * fix: move timer * fix: add different effect * Fix balanceToString Co-authored-by: Ilan <ilanolkies@outlook.com> * Enhancement/live txs (#129) * added live balances * minor changes * RIF Sockets Context * URL based on platform and exporting rifWalletServicesUrl variable * Adding socket.io-client * Wrapping app with RIFSocketsProvider * Implementing live prices * Lifting state for activities/transactions * Lifting balances state * Lint * Update src/core/setup.ts Co-authored-by: Christian Escalante <chescalante.ar@gmail.com> * Lint * Fixing test * Move service url to config * connected home with tokens and transactions state * fixed tests and added polimophic socket class (#121) Co-authored-by: Christian Escalante <chescalante@gmail.com> * Moved subscriptions instance to Core + added ABI Enhancer after receiving a transaction * Lint * Changing to new state structure * Changing state structure to match enhanced transactions * Implementing top 5 enhanced transactions * Implementing FlatList component to render transactionsç * Implementing FlatList to implement infinite scrolling * Lint * Fixing test * Removing data array from the state structure, because its duplicating the txs * Lint * Sorting by timestamp * Fixing sorting funciton * Changing filtering to use hash since its unique Co-authored-by: Christian Escalante <chescalante@gmail.com> Co-authored-by: Agustin Villalobos <agustin.villalobos@iovlabs.org> Co-authored-by: Christian Escalante <chescalante.ar@gmail.com> Co-authored-by: Ilan <ilanolkies@outlook.com> Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com> * Update Active Row Component when balance/wallet changes (#148) * Start working on storing a reference (contractAddress) rather than the object * Clean up comments and use new value. * Remove conosle.log * Remove unnecessary filter and call address directly if available * Section component to render options in settings * Implementing sections * Adding translate to section titles * Adding props to setting screen * Passing deleteKeys function down to the settings screen * removing delete keys button * Adding condition in case the key doesnt exist in the send screen and also deleting the deletekeys button from keysinfo screen * Fixing test * Implemenenting information section * Rebasing Core * Adding testing * Add button to manage wallets. Co-authored-by: Agustin Villalobos <agustin.villalobos@iovlabs.org> Co-authored-by: Jesse Clark <hello@developerjesse.com> Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com> Co-authored-by: Ilan <ilanolkies@outlook.com> Co-authored-by: Luis Chavarría <luis.chavarria@iovlabs.org> Co-authored-by: Christian Escalante <chescalante@gmail.com> Co-authored-by: Christian Escalante <chescalante.ar@gmail.com>

feat: connect faucets component

dc042fe

lucachaco requested a review from ilanolkies February 2, 2022 03:39

chore: add comment

fcc1bf3

jessgusclark reviewed Feb 2, 2022

View reviewed changes

lucachaco added 3 commits February 2, 2022 17:16

feat: add rbtc balance

a0e875d

feat: add rbtc balance

8b539a9

fix: refactor test

b80d56a

lucachaco requested a review from jessgusclark February 3, 2022 05:48

chore: remove console

5f43ded

ilanolkies added the bug Something isn't working label Feb 3, 2022

ilanolkies added this to the v1.0.0 milestone Feb 3, 2022

ilanolkies reviewed Feb 3, 2022

View reviewed changes

jessgusclark requested changes Feb 3, 2022

View reviewed changes

fix: validate balances

5b4e6ad

lucachaco requested a review from jessgusclark February 3, 2022 21:29

ilanolkies suggested changes Feb 4, 2022

View reviewed changes

jessgusclark requested changes Feb 4, 2022

View reviewed changes

lucachaco added 3 commits February 6, 2022 18:13

Merge branch 'develop' into US-556

51962ef

format: lint code

9585c47

fix: load rbtc balance with serInterval

578a94d

lucachaco requested review from jessgusclark and ilanolkies February 7, 2022 01:32

ilanolkies suggested changes Feb 7, 2022

View reviewed changes

fix: move rbtc load code

07b4906

lucachaco force-pushed the US-556 branch from baa512b to 07b4906 Compare February 7, 2022 18:34

lucachaco added 3 commits February 7, 2022 12:37

format: lint code

8f4c36d

fix: move code

3bf73a1

fix: remove duplicated line

cf86ce4

lucachaco added 3 commits February 7, 2022 12:54

fix: add missing types

de9ca19

fix: add todo comment

ff636f0

fix: move timer

53b9341

lucachaco requested a review from ilanolkies February 8, 2022 00:29

jessgusclark mentioned this pull request Feb 8, 2022

Allow the user to add new accounts and switch to them #144

Merged

ilanolkies suggested changes Feb 8, 2022

View reviewed changes

fix: add different effect

6049933

lucachaco requested a review from ilanolkies February 8, 2022 23:03

ilanolkies reviewed Feb 8, 2022

View reviewed changes

Fix balanceToString

0ae39d8

ilanolkies approved these changes Feb 8, 2022

View reviewed changes

jessgusclark approved these changes Feb 9, 2022

View reviewed changes

ilanolkies merged commit e44c660 into develop Feb 9, 2022

lucachaco deleted the US-556 branch December 19, 2022 21:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: connect faucets component #139

feat: connect faucets component #139

lucachaco commented Feb 2, 2022 •

edited

Loading

jessgusclark Feb 2, 2022

jessgusclark left a comment

ilanolkies left a comment

lucachaco commented Feb 3, 2022 •

edited

Loading

jessgusclark left a comment

jessgusclark Feb 3, 2022

jessgusclark Feb 3, 2022

jessgusclark Feb 3, 2022

ilanolkies left a comment

ilanolkies Feb 3, 2022

ilanolkies Feb 3, 2022

jessgusclark Feb 4, 2022

jessgusclark left a comment •

edited

Loading

ilanolkies left a comment

ilanolkies Feb 7, 2022

ilanolkies Feb 7, 2022

ilanolkies left a comment

ilanolkies Feb 8, 2022

ilanolkies left a comment

ilanolkies commented Feb 8, 2022

feat: connect faucets component #139

feat: connect faucets component #139

Conversation

lucachaco commented Feb 2, 2022 • edited Loading

Choose a reason for hiding this comment

jessgusclark left a comment

Choose a reason for hiding this comment

ilanolkies left a comment

Choose a reason for hiding this comment

lucachaco commented Feb 3, 2022 • edited Loading

jessgusclark left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ilanolkies left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jessgusclark left a comment • edited Loading

Choose a reason for hiding this comment

ilanolkies left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ilanolkies left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ilanolkies left a comment

Choose a reason for hiding this comment

ilanolkies commented Feb 8, 2022

lucachaco commented Feb 2, 2022 •

edited

Loading

lucachaco commented Feb 3, 2022 •

edited

Loading

jessgusclark left a comment •

edited

Loading