Allow the user to add new accounts and switch to them #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessgusclark
changed the title
ilanolkies
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
LRGTM! Clean,
Deleting the keys and reimporting the app will result in only loading the first wallet (as expected)
We can build a strategy for recovery, iterating inspecting balances of nextWallet
will connect to any address
Cool 👍
I chose to skip the tests on the BalanceScreen for two reasons
Ok, agree. We need to work on that
ilanolkies
added a commit
that referenced
this pull request
Feb 10, 2022
* Section component to render options in settings * Implementing sections * Adding translate to section titles * Adding props to setting screen * Passing deleteKeys function down to the settings screen * removing delete keys button * Adding condition in case the key doesnt exist in the send screen and also deleting the deletekeys button from keysinfo screen * Fixing test * Allow the user to add new accounts and switch to them (#144) * Add screen for managing current wallet. * Pass addNewWallet to manage wallets screen. * Allow the user to switch the selectedWallet in the core. * Show addresses in manage screen. * In sockets file, move connect() feature outside of the useEffect. * combine functions into single useEffect and remove check for if wallet is deployed. * Remove unused variables, add sockets method and use it. * Add wallet and isDeployed to the list when clicking the button. * Clean up addWallet code. * Move next wallet creation to the operations file. * Pass networkId * Skipping these tests, see PR description. * Export props and use in RootNavigation * Enhancemnt/no usd value (#146) * Adding not available message to the balance row component * Linting * Simplifying quota prop * Update src/screens/home/BalanceRowComponent.tsx * Make USD text smaller Co-authored-by: Agustin Villalobos <agustin.villalobos@iovlabs.org> Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com> Co-authored-by: Ilan <ilanolkies@outlook.com> * feat: connect faucets component (#139) * feat: connect faucets component * chore: add comment * feat: add rbtc balance * feat: add rbtc balance * fix: refactor test * chore: remove console * fix: validate balances * format: lint code * fix: load rbtc balance with serInterval * fix: move rbtc load code * format: lint code * fix: move code * fix: remove duplicated line * fix: add missing types * fix: add todo comment * fix: move timer * fix: add different effect * Fix balanceToString Co-authored-by: Ilan <ilanolkies@outlook.com> * Enhancement/live txs (#129) * added live balances * minor changes * RIF Sockets Context * URL based on platform and exporting rifWalletServicesUrl variable * Adding socket.io-client * Wrapping app with RIFSocketsProvider * Implementing live prices * Lifting state for activities/transactions * Lifting balances state * Lint * Update src/core/setup.ts Co-authored-by: Christian Escalante <chescalante.ar@gmail.com> * Lint * Fixing test * Move service url to config * connected home with tokens and transactions state * fixed tests and added polimophic socket class (#121) Co-authored-by: Christian Escalante <chescalante@gmail.com> * Moved subscriptions instance to Core + added ABI Enhancer after receiving a transaction * Lint * Changing to new state structure * Changing state structure to match enhanced transactions * Implementing top 5 enhanced transactions * Implementing FlatList component to render transactionsç * Implementing FlatList to implement infinite scrolling * Lint * Fixing test * Removing data array from the state structure, because its duplicating the txs * Lint * Sorting by timestamp * Fixing sorting funciton * Changing filtering to use hash since its unique Co-authored-by: Christian Escalante <chescalante@gmail.com> Co-authored-by: Agustin Villalobos <agustin.villalobos@iovlabs.org> Co-authored-by: Christian Escalante <chescalante.ar@gmail.com> Co-authored-by: Ilan <ilanolkies@outlook.com> Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com> * Update Active Row Component when balance/wallet changes (#148) * Start working on storing a reference (contractAddress) rather than the object * Clean up comments and use new value. * Remove conosle.log * Remove unnecessary filter and call address directly if available * Section component to render options in settings * Implementing sections * Adding translate to section titles * Adding props to setting screen * Passing deleteKeys function down to the settings screen * removing delete keys button * Adding condition in case the key doesnt exist in the send screen and also deleting the deletekeys button from keysinfo screen * Fixing test * Implemenenting information section * Rebasing Core * Adding testing * Add button to manage wallets. Co-authored-by: Agustin Villalobos <agustin.villalobos@iovlabs.org> Co-authored-by: Jesse Clark <hello@developerjesse.com> Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com> Co-authored-by: Ilan <ilanolkies@outlook.com> Co-authored-by: Luis Chavarría <luis.chavarria@iovlabs.org> Co-authored-by: Christian Escalante <chescalante@gmail.com> Co-authored-by: Christian Escalante <chescalante.ar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to switch to add accounts and switch to them. The UX is a bit rough but the functionality is there. I will wait for the updated design before continuing.
other notable things
expected conflicts
This PR will have conflicts with the following PRS:
BalanceScreen tests are being skipped.
I chose to skip the tests on the BalanceScreen for two reasons:
First, the BalanceScreen is an older screen that is only accessible from the Dev menu. In the near future this will be removed.
Second, and more importantly, the BalanceScreen should not rely on the RIFWalletSockets class. Rather, the component should take
balancesas a parameter and display them accordingly. The existing pattern makes it very difficult to reuse the component. A better solution would be to elevate the balances to the Core.tsx and pass it down to each component. We should do this, but since this screen will be deprecated soon it did not make sense to fix this here.