Enhancement/improve settings #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 4, 2022 08:15
added 2 commits
February 7, 2022 13:57
…also deleting the deletekeys button from keysinfo screen
jessgusclark
requested changes
Feb 8, 2022
There was a problem hiding this comment.
A few notes:
- please fetch the latest changes from
developand rebase. - missing test for the new file.
- the "information" section is empty. Version can be retreived from package.json, contracts from wallet.smartwallet.smartWalletFactory.address (I think) and I dunno what 'connectivity' is
* Add screen for managing current wallet. * Pass addNewWallet to manage wallets screen. * Allow the user to switch the selectedWallet in the core. * Show addresses in manage screen. * In sockets file, move connect() feature outside of the useEffect. * combine functions into single useEffect and remove check for if wallet is deployed. * Remove unused variables, add sockets method and use it. * Add wallet and isDeployed to the list when clicking the button. * Clean up addWallet code. * Move next wallet creation to the operations file. * Pass networkId * Skipping these tests, see PR description. * Export props and use in RootNavigation
* Adding not available message to the balance row component * Linting * Simplifying quota prop * Update src/screens/home/BalanceRowComponent.tsx * Make USD text smaller Co-authored-by: Agustin Villalobos <agustin.villalobos@iovlabs.org> Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com> Co-authored-by: Ilan <ilanolkies@outlook.com>
* feat: connect faucets component * chore: add comment * feat: add rbtc balance * feat: add rbtc balance * fix: refactor test * chore: remove console * fix: validate balances * format: lint code * fix: load rbtc balance with serInterval * fix: move rbtc load code * format: lint code * fix: move code * fix: remove duplicated line * fix: add missing types * fix: add todo comment * fix: move timer * fix: add different effect * Fix balanceToString Co-authored-by: Ilan <ilanolkies@outlook.com>
* added live balances * minor changes * RIF Sockets Context * URL based on platform and exporting rifWalletServicesUrl variable * Adding socket.io-client * Wrapping app with RIFSocketsProvider * Implementing live prices * Lifting state for activities/transactions * Lifting balances state * Lint * Update src/core/setup.ts Co-authored-by: Christian Escalante <chescalante.ar@gmail.com> * Lint * Fixing test * Move service url to config * connected home with tokens and transactions state * fixed tests and added polimophic socket class (#121) Co-authored-by: Christian Escalante <chescalante@gmail.com> * Moved subscriptions instance to Core + added ABI Enhancer after receiving a transaction * Lint * Changing to new state structure * Changing state structure to match enhanced transactions * Implementing top 5 enhanced transactions * Implementing FlatList component to render transactionsç * Implementing FlatList to implement infinite scrolling * Lint * Fixing test * Removing data array from the state structure, because its duplicating the txs * Lint * Sorting by timestamp * Fixing sorting funciton * Changing filtering to use hash since its unique Co-authored-by: Christian Escalante <chescalante@gmail.com> Co-authored-by: Agustin Villalobos <agustin.villalobos@iovlabs.org> Co-authored-by: Christian Escalante <chescalante.ar@gmail.com> Co-authored-by: Ilan <ilanolkies@outlook.com> Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com>
* Start working on storing a reference (contractAddress) rather than the object * Clean up comments and use new value. * Remove conosle.log * Remove unnecessary filter and call address directly if available
…also deleting the deletekeys button from keysinfo screen
added 3 commits
February 9, 2022 13:37
…allet into enhancement/improve-settings
|
|
There was a problem hiding this comment.
I have no idea what happened with the commits, it seems like the files changed included code that was already merged into develop.
Anywho, This looks good to me, I just added one additional commit adding the button for switching/managing wallets. This screen looks very nice!
jessgusclark
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2022-02-07.at.13.44.43.mov