Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project-specific plugin model #10

Closed
wintondeshong opened this issue Oct 3, 2019 · 2 comments · Fixed by #105
Closed

Project-specific plugin model #10

wintondeshong opened this issue Oct 3, 2019 · 2 comments · Fixed by #105
Assignees
@brandongregoryscott
Labels
enhancement New feature or request hacktoberfest Support hacktoberfest (not required to get credit)

Comments

@wintondeshong
Copy link
Contributor

wintondeshong commented Oct 3, 2019 •
edited
Loading

Currently the and-cli is written to be abstract and work for our projects. Inevitably we will want to write some additional commands that we want to remain outside of the and-cli and reside in the project repository.

This issue is to create a plugin model for the and-cli to allow a project to extend the commands. While there could be many ways to do this, it would be ideal from a usage perspective not to have to add any additional configuration for to work.
@wintondeshong wintondeshong added enhancement New feature or request hacktoberfest Support hacktoberfest (not required to get credit) labels Oct 3, 2019
@wintondeshong wintondeshong added the pregroom Pending additional details before it is ready to be worked on label Oct 3, 2019
@wintondeshong wintondeshong removed the pregroom Pending additional details before it is ready to be worked on label Oct 15, 2019
@brandongregoryscott brandongregoryscott mentioned this issue Apr 2, 2020
Closed
@brandongregoryscott brandongregoryscott self-assigned this Aug 20, 2020
@brandongregoryscott
Copy link
Contributor

Going to assign myself for now - I've been hacking in my free time to get a prototype/proof-of-concept working. Running into some interesting performance issues with the restructuring I did, so I've got to work through that.

@brandongregoryscott brandongregoryscott mentioned this issue Sep 12, 2020
Merged
9 tasks
brandongregoryscott added a commit that referenced this issue Sep 14, 2020
@brandongregoryscott
Issue #10 Project-specific plugin model
a93b150 
Fixes #10 Project-specific plugin model
Fixes #104 Assignment to constant variable error in dotnet-test module

This PR introduces the ability to import & build on top of the base and-cli project. There is a new module built around management of the commands registered with the commander package, named command-registry. It provides functions for registering commands, registering base commands, removing commands, etc., with appropriate validation of each action (for example, you will get a warning when attempting to register a command of the same name unless you opt in with a flag).

Throughout the development of this feature, I built up an example project to showcase how a consuming project might use this plugin/extension model. See this repo here: https://github.com/AndcultureCode/AndcultureCode.Cli.PluginExample
@brandongregoryscott
Copy link
Contributor

Published in v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandongregoryscott brandongregoryscott

Labels
enhancement New feature or request hacktoberfest Support hacktoberfest (not required to get credit)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #10 Project-specific plugin model, commandRegistry module & uni…
3 participants
@wintondeshong @snsavage @brandongregoryscott