Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for v2 and hybrid torrent files #6

Open
past-due opened this issue Dec 3, 2020 · 2 comments
Open

Support for v2 and hybrid torrent files #6

past-due opened this issue Dec 3, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers security Related to potential or actual security vulnerabilities

Comments

@past-due
Copy link

past-due commented Dec 3, 2020

See: https://blog.libtorrent.org/2020/09/bittorrent-v2/

v2 moves to SHA-256 hashes. It is possible to create hybrid torrents that support v1 and v2 swarms at the same time.

SHA-1 chosen-prefix attacks are now in the USD 10k-100k range.

Reference: pobrn/mktorrent#29 (comment)

Given all of the above, I think there'd be a great benefit to supporting v2-only, and hybrid torrent file generation (in addition to the current v1-only support).

@rsnitsch rsnitsch added enhancement New feature or request good first issue Good for newcomers labels Dec 4, 2020
@rsnitsch
Copy link
Owner

rsnitsch commented Dec 4, 2020

Thank you very much for making me aware of this. It will be on the top of my TODO list.

@rsnitsch rsnitsch added the security Related to potential or actual security vulnerabilities label Dec 4, 2020
@rsnitsch
Copy link
Owner

rsnitsch commented Dec 4, 2020

Relevant BEPs:
https://www.bittorrent.org/beps/bep_0003.html (v1)
https://www.bittorrent.org/beps/bep_0047.html (padding)
https://www.bittorrent.org/beps/bep_0052.html (hybrid/v2, which requires padding according to BEP 47)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers security Related to potential or actual security vulnerabilities
Projects
None yet
Development

No branches or pull requests

2 participants