Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io.reactivesocket.rx.* package #67

Closed
benjchristensen opened this issue Sep 25, 2015 · 1 comment
Closed

io.reactivesocket.rx.* package #67

benjchristensen opened this issue Sep 25, 2015 · 1 comment

Comments

@benjchristensen
Copy link
Contributor

I'm not thrilled about this package existing: https://github.com/ReactiveSocket/reactivesocket-java/tree/master/src/main/java/io/reactivesocket/rx

The Completable is useful, but I don't yet know if it will make it into RxJava v2. Where should that type go?

As for the Observable types, it would be better to use RxJava v2 at some point if these exist. Or can we somehow use just the java.util.function.Consumer class for these use cases? I haven't convinced myself yet whether we actually need the onError/onComplete terminal events on this, as the only reason we use it is to expose DuplexConnection.getInput, and that should never invoke onComplete. A connection can fail, but perhaps we should have a different way of signaling that, since an error should affect the entire connection, not just input or output.

@NiteshKant
Copy link
Contributor

0.5.x gets rid of this package. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants