Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge repository #1

Closed
scolladon opened this issue Jun 4, 2020 · 2 comments
Closed

Merge repository #1

scolladon opened this issue Jun 4, 2020 · 2 comments

Comments

@scolladon
Copy link

Hi Robert,

Do you think we should merge our repository ? https://github.com/scolladon/apex-chainable
We had a very similar approach !

I am available to discuss with you !

  • Current choices,
  • Challenges faced
  • Next feature to add

Seb
@rsoesemann
Copy link
Owner

rsoesemann commented Jun 4, 2020 •
edited
Loading

Hi I see no reasons to merge two libs just because of similar base ideas. Who would benefit from that. Besides that I think your code looks more more complicated. Less lean and clean... Feel free to open a fork with a merge and pr it.

@rsoesemann rsoesemann reopened this Jun 4, 2020
@scolladon
Copy link
Author

I see your point.

Thanks for the encouragement to collaborate on this project.
If you have time, I'll be happy to hear what you would do to improve the code of apex-chainable.
I'm available on gitter

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scolladon @rsoesemann