[BUG] Disabling greylisting fails if you've greylist action in local.d/actions.conf

[whataboutpereira]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Read about bug reporting in general: https://rspamd.com/doc/faq.html#how-to-report-bugs-found-in-rspamd
  • Enabled relevant debugging logs: https://rspamd.com/doc/faq.html#how-to-debug-some-module-in-rspamd
  • Checked the FAQs about Core files in case of fatal crash: https://rspamd.com/doc/faq.html#how-to-figure-out-why-rspamd-process-crashed
  • Tried ASAN package and obtained the ASAN report (if possible): https://rspamd.com/doc/faq.html#asan-builds
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=%E2%9C%93&q=is%3Aissue+user%3Arspamd
  • Checked that there is not already an experimental package or master branch

Describe the bug
My attempts to disable greylisting failed when I added enabled = false; in local.d/greylist.conf - all mails over greylist limit were indefinitely greylisted.

Looking closer I noticed I had overwritten greylist threshold with greylist = 6 in local.d/actions.conf. A combination of overwritten greylist action and disabled greylisting causes all mails over the greylist limit to be indefinitely greylisted.

Steps to Reproduce

1. Add greylist = n; in local.d/actions.conf to change the default greylist limit of 4.
2. Disable greylisting by adding enabled = false; to local.d/greylist.conf

Expected behavior
Greylisting should be completely disabled, but instead all mails over greylist threshold defined in local.d/actions.conf will be indefinitely greylisted.

Versions

CentOS 7
Rspamd 2.4

Additional Information

Disabling greylisting works only if there is no greylist = n; in local.d/actions.conf or it is set to greylist = null;

[vstakhov]

What is indefinitely greylisted? Soft reject on all messages? If yes, then it cannot be.

[whataboutpereira]

Yes, they're all soft reject'ed until I remove the action from local.d/actions.conf or set it to null.

[vstakhov]

Soft rejection is added by greylist module. If it is disabled then you won't see soft rejections. Can you confirm that this module is disabled (rspamadm configdump -m)?

[whataboutpereira]

Modules disabled (explicitly): greylist

Actually IIRC the UI showed soft reject, but logs show:

default: T (greylist): [7.33/15.00]

[vstakhov]

So everything works as expected. No issue here.

[whataboutpereira]

Do I understand correct that the "greylist" action is just blindly added when actual greylisting is disabled (because it's defined in local.d/actions.conf)?

Should it be so?

Should I make a pull request for disable greylist documentation in the FAQ cautioning that you need to remove or nullify greylist in local.d/actions.conf if it's overwritten there?

[whataboutpereira]

I ran into the problem because OpenSMTPD filter-rspamd responds to both 'soft reject' and 'greylist' actions with a temporary failure.

[vstakhov]

In theory, greylist action is threshold only action. It should not be added as the resulting action. I will check that and think what should be done.

[vstakhov]

So the issue should be like 'do not add threshold only actions as a result'.

[whataboutpereira]

Thanks for thinking with me! :)

[whataboutpereira]

Would this in local.d/actions.conf avoid the problem?

greylist = {
 score = 6.0,
 flags = ["no_action"],
}

[vstakhov]

                else if (i == METRIC_ACTION_GREYLIST) {
			action->flags |= RSPAMD_ACTION_THRESHOLD_ONLY|RSPAMD_ACTION_HAM;
		}

So this is already applied to greylist action. But you can try to add these flags: ["threshold_only", "ham"] to this action.

[whataboutpereira]

Does METRIC_ACTION_GREYLIST apply when actual greylisting is disabled?