Skip to content

Commit

Permalink
Fix example formatter output.
Browse files Browse the repository at this point in the history
My changes (particularly the pending changes) have changed the backtraces a bit and forced me to re-generate these.  I'm having issues running the specs on JRuby so I wasn't able to re-gen those.
  • Loading branch information
myronmarston committed Nov 7, 2010
1 parent 2a03730 commit 4b714e7
Show file tree
Hide file tree
Showing 8 changed files with 255 additions and 192 deletions.
82 changes: 49 additions & 33 deletions spec/rspec/core/formatters/html_formatted-1.8.6.html
Expand Up @@ -184,7 +184,7 @@ <h1>RSpec Code Examples</h1>
<dt id="example_group_1">pending spec with no implementation</dt>
<script type="text/javascript">makeYellow('rspec-header');</script>
<script type="text/javascript">makeYellow('example_group_1');</script>
<script type="text/javascript">moveProgressBar('20.0');</script>
<script type="text/javascript">moveProgressBar('14.2');</script>
<dd class="spec not_implemented"><span class="not_implemented_spec_name">is pending (PENDING: Not Yet Implemented)</span></dd>
</dl>
</div>
Expand All @@ -198,7 +198,7 @@ <h1>RSpec Code Examples</h1>
<dt id="example_group_3">with content that would fail</dt>
<script type="text/javascript">makeYellow('rspec-header');</script>
<script type="text/javascript">makeYellow('example_group_3');</script>
<script type="text/javascript">moveProgressBar('40.0');</script>
<script type="text/javascript">moveProgressBar('28.5');</script>
<dd class="spec not_implemented"><span class="not_implemented_spec_name">is pending (PENDING: No reason given)</span></dd>
</dl>
</div>
Expand All @@ -207,43 +207,39 @@ <h1>RSpec Code Examples</h1>
<dt id="example_group_4">with content that would pass</dt>
<script type="text/javascript">makeRed('rspec-header');</script>
<script type="text/javascript">makeRed('example_group_4');</script>
<script type="text/javascript">moveProgressBar('60.0');</script>
<script type="text/javascript">moveProgressBar('42.8');</script>
<dd class="spec pending_fixed">
<span class="failed_spec_name">fails</span>
<div class="failure" id="failure_0">
<div class="message"><pre>RSpec::Core::PendingExampleFixedError</pre></div>
<div class="backtrace"><pre>./spec/rspec/core/resources/formatter_specs.rb:19
./spec/rspec/core/formatters/html_formatter_spec.rb:23
./spec/rspec/core/formatters/html_formatter_spec.rb:43
./spec/rspec/core/formatters/html_formatter_spec.rb:43:in `open'
./spec/rspec/core/formatters/html_formatter_spec.rb:43
./spec/rspec/core/formatters/html_formatter_spec.rb:42:in `chdir'
./spec/rspec/core/formatters/html_formatter_spec.rb:42
./spec/spec_helper.rb:70:in `__instance_exec0'
./spec/spec_helper.rb:46:in `instance_eval'
./spec/spec_helper.rb:46:in `sandboxed'
./spec/spec_helper.rb:70:in `__instance_exec0'</pre></div>
<pre class="ruby"><code><span class="linenum">11</span> <span class="keyword">rescue</span> <span class="constant">Exception</span> <span class="punct">=&gt;</span> <span class="ident">e</span>
<span class="linenum">12</span> <span class="keyword">end</span>
<span class="offending"><span class="linenum">13</span> <span class="keyword">raise</span> <span class="constant">RSpec</span><span class="punct">::</span><span class="constant">Core</span><span class="punct">::</span><span class="constant">PendingExampleFixedError</span><span class="punct">.</span><span class="ident">new</span> <span class="keyword">if</span> <span class="ident">result</span></span>
<span class="linenum">14</span> <span class="keyword">end</span>
<span class="linenum">15</span> <span class="ident">throw</span> <span class="symbol">:pending_declared_in_example</span><span class="punct">,</span> <span class="ident">message</span></code></pre>
<div class="backtrace"><pre>./spec/rspec/core/resources/formatter_specs.rb:18
./spec/rspec/core/formatters/html_formatter_spec.rb:24
./spec/rspec/core/formatters/html_formatter_spec.rb:46
./spec/rspec/core/formatters/html_formatter_spec.rb:46:in `open'
./spec/rspec/core/formatters/html_formatter_spec.rb:46
./spec/rspec/core/formatters/html_formatter_spec.rb:45:in `chdir'
./spec/rspec/core/formatters/html_formatter_spec.rb:45</pre></div>
<pre class="ruby"><code><span class="linenum">20</span> <span class="keyword">rescue</span> <span class="constant">Exception</span> <span class="punct">=&gt;</span> <span class="ident">e</span>
<span class="linenum">21</span> <span class="keyword">end</span>
<span class="offending"><span class="linenum">22</span> <span class="keyword">raise</span> <span class="constant">RSpec</span><span class="punct">::</span><span class="constant">Core</span><span class="punct">::</span><span class="constant">PendingExampleFixedError</span><span class="punct">.</span><span class="ident">new</span> <span class="keyword">if</span> <span class="ident">result</span></span>
<span class="linenum">23</span> <span class="keyword">end</span>
<span class="linenum">24</span> <span class="ident">throw</span> <span class="symbol">:pending_declared_in_example</span><span class="punct">,</span> <span class="ident">message</span></code></pre>
</div>
</dd>
</dl>
</div>
<div class="example_group">
<dl>
<dt id="example_group_5">passing spec</dt>
<script type="text/javascript">moveProgressBar('80.0');</script>
<script type="text/javascript">moveProgressBar('57.1');</script>
<dd class="spec passed"><span class="passed_spec_name">passes</span></dd>
</dl>
</div>
<div class="example_group">
<dl>
<dt id="example_group_6">failing spec</dt>
<script type="text/javascript">makeRed('example_group_6');</script>
<script type="text/javascript">moveProgressBar('100.0');</script>
<script type="text/javascript">moveProgressBar('71.4');</script>
<dd class="spec failed">
<span class="failed_spec_name">fails</span>
<div class="failure" id="failure_0">
Expand All @@ -253,17 +249,13 @@ <h1>RSpec Code Examples</h1>

(compared using ==)
</pre></div>
<div class="backtrace"><pre>./spec/rspec/core/resources/formatter_specs.rb:34
./spec/rspec/core/formatters/html_formatter_spec.rb:23
./spec/rspec/core/formatters/html_formatter_spec.rb:43
./spec/rspec/core/formatters/html_formatter_spec.rb:43:in `open'
./spec/rspec/core/formatters/html_formatter_spec.rb:43
./spec/rspec/core/formatters/html_formatter_spec.rb:42:in `chdir'
./spec/rspec/core/formatters/html_formatter_spec.rb:42
./spec/spec_helper.rb:70:in `__instance_exec0'
./spec/spec_helper.rb:46:in `instance_eval'
./spec/spec_helper.rb:46:in `sandboxed'
./spec/spec_helper.rb:70:in `__instance_exec0'</pre></div>
<div class="backtrace"><pre>./spec/rspec/core/resources/formatter_specs.rb:33
./spec/rspec/core/formatters/html_formatter_spec.rb:24
./spec/rspec/core/formatters/html_formatter_spec.rb:46
./spec/rspec/core/formatters/html_formatter_spec.rb:46:in `open'
./spec/rspec/core/formatters/html_formatter_spec.rb:46
./spec/rspec/core/formatters/html_formatter_spec.rb:45:in `chdir'
./spec/rspec/core/formatters/html_formatter_spec.rb:45</pre></div>
<pre class="ruby"><code><span class="linenum">27</span> <span class="keyword">end</span>
<span class="linenum">28</span>
<span class="offending"><span class="linenum">29</span> <span class="keyword">raise</span><span class="punct">(</span><span class="constant">RSpec</span><span class="punct">::</span><span class="constant">Expectations</span><span class="punct">::</span><span class="constant">ExpectationNotMetError</span><span class="punct">.</span><span class="ident">new</span><span class="punct">(</span><span class="ident">message</span><span class="punct">))</span></span>
Expand All @@ -272,8 +264,32 @@ <h1>RSpec Code Examples</h1>
</dd>
</dl>
</div>
<div class="example_group">
<dl>
<dt id="example_group_7">a failing spec with odd backtraces</dt>
<script type="text/javascript">makeRed('example_group_7');</script>
<script type="text/javascript">moveProgressBar('85.7');</script>
<dd class="spec failed">
<span class="failed_spec_name">fails with a backtrace that has no file</span>
<div class="failure" id="failure_0">
<div class="message"><pre>foo</pre></div>
<div class="backtrace"><pre>(erb):1</pre></div>
<pre class="ruby"><code><span class="linenum">-1</span><span class="comment"># Couldn't get snippet for (erb)</span></code></pre>
</div>
</dd>
<script type="text/javascript">moveProgressBar('100.0');</script>
<dd class="spec failed">
<span class="failed_spec_name">fails with a backtrace containing an erb file</span>
<div class="failure" id="failure_0">
<div class="message"><pre>Exception</pre></div>
<div class="backtrace"><pre>/foo.html.erb:1:in `<main>': foo (RuntimeError)</pre></div>
<pre class="ruby"><code><span class="linenum">-1</span><span class="comment"># Couldn't get snippet for /foo.html.erb</span></code></pre>
</div>
</dd>
</dl>
</div>
<script type="text/javascript">document.getElementById('duration').innerHTML = "Finished in <strong>x seconds</strong>";</script>
<script type="text/javascript">document.getElementById('totals').innerHTML = "5 examples, 2 failures, 2 pending";</script>
<script type="text/javascript">document.getElementById('totals').innerHTML = "7 examples, 4 failures, 2 pending";</script>
</div>
</div>
</body>
Expand Down
10 changes: 5 additions & 5 deletions spec/rspec/core/formatters/html_formatted-1.8.7.html
Expand Up @@ -219,11 +219,11 @@ <h1>RSpec Code Examples</h1>
./spec/rspec/core/formatters/html_formatter_spec.rb:46
./spec/rspec/core/formatters/html_formatter_spec.rb:45:in `chdir'
./spec/rspec/core/formatters/html_formatter_spec.rb:45</pre></div>
<pre class="ruby"><code><span class="linenum">11</span> <span class="keyword">rescue</span> <span class="constant">Exception</span> <span class="punct">=&gt;</span> <span class="ident">e</span>
<span class="linenum">12</span> <span class="keyword">end</span>
<span class="offending"><span class="linenum">13</span> <span class="keyword">raise</span> <span class="constant">RSpec</span><span class="punct">::</span><span class="constant">Core</span><span class="punct">::</span><span class="constant">PendingExampleFixedError</span><span class="punct">.</span><span class="ident">new</span> <span class="keyword">if</span> <span class="ident">result</span></span>
<span class="linenum">14</span> <span class="keyword">end</span>
<span class="linenum">15</span> <span class="ident">throw</span> <span class="symbol">:pending_declared_in_example</span><span class="punct">,</span> <span class="ident">message</span></code></pre>
<pre class="ruby"><code><span class="linenum">20</span> <span class="keyword">rescue</span> <span class="constant">Exception</span> <span class="punct">=&gt;</span> <span class="ident">e</span>
<span class="linenum">21</span> <span class="keyword">end</span>
<span class="offending"><span class="linenum">22</span> <span class="keyword">raise</span> <span class="constant">RSpec</span><span class="punct">::</span><span class="constant">Core</span><span class="punct">::</span><span class="constant">PendingExampleFixedError</span><span class="punct">.</span><span class="ident">new</span> <span class="keyword">if</span> <span class="ident">result</span></span>
<span class="linenum">23</span> <span class="keyword">end</span>
<span class="linenum">24</span> <span class="ident">throw</span> <span class="symbol">:pending_declared_in_example</span><span class="punct">,</span> <span class="ident">message</span></code></pre>
</div>
</dd>
</dl>
Expand Down

0 comments on commit 4b714e7

Please sign in to comment.