Skip to content

Commit

Permalink
Standardize bisect progress output on "failing" over "failed".
Browse files Browse the repository at this point in the history
  • Loading branch information
myronmarston committed Apr 6, 2015
1 parent 04d3f5e commit cf48b93
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/rspec/core/formatters/bisect_progress_formatter.rb
Expand Up @@ -19,7 +19,7 @@ def bisect_starting(notification)
end

def bisect_original_run_complete(notification)
failures = Helpers.pluralize(notification.failed_example_ids.size, "failed example")
failures = Helpers.pluralize(notification.failed_example_ids.size, "failing example")
non_failures = Helpers.pluralize(notification.non_failing_example_ids.size, "non-failing example")

output.puts " (#{Helpers.format_duration(notification.duration)})"
Expand Down
4 changes: 2 additions & 2 deletions spec/integration/bisect_spec.rb
Expand Up @@ -22,7 +22,7 @@ def bisect(cli_args, expected_status=nil)
expect(output).to eq(<<-EOS.gsub(/^\s+\|/, ''))
|Bisect started using options: "spec/rspec/core/resources/order_dependent_specs.rb --order defined"
|Running suite to find failures... (n.nnnn seconds)
|Starting bisect with 1 failed example and 21 non-failing examples.
|Starting bisect with 1 failing example and 21 non-failing examples.
|
|Round 1: searching for 11 non-failing examples (of 21) to ignore: .. (n.nnnn seconds)
|Round 2: searching for 6 non-failing examples (of 11) to ignore: . (n.nnnn seconds)
Expand Down Expand Up @@ -138,7 +138,7 @@ def bisect_round_finished(notification)
expect(output).to eq(<<-EOS.gsub(/^\s+\|/, ''))
|Bisect started using options: "spec/rspec/core/resources/order_dependent_specs.rb --order defined"
|Running suite to find failures... (n.nnnn seconds)
|Starting bisect with 1 failed example and 21 non-failing examples.
|Starting bisect with 1 failing example and 21 non-failing examples.
|
|Round 1: searching for 11 non-failing examples (of 21) to ignore: .. (n.nnnn seconds)
|Round 2: searching for 6 non-failing examples (of 11) to ignore: .
Expand Down

0 comments on commit cf48b93

Please sign in to comment.