Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rspec --init so that it enables warnings in commented out spec_helper rather than in .rspec #1571

Closed
myronmarston opened this issue Jun 3, 2014 · 7 comments

Comments

@myronmarston
Copy link
Member

...from a twitter conversation:

https://twitter.com/myronmarston/status/473646079280300032

@GeekOnCoffee
Copy link
Contributor

Awesome. took a brief look to see if I could quickly figure out where this was happening, with little success... if nobody else gets to it, I'll try and dig in when I get a chance.

@myronmarston
Copy link
Member Author

Basically, we just need to remove this line:

...and add config.warnings = true to this file:

https://github.com/rspec/rspec-core/blob/master/lib/rspec/core/project_initializer/spec/spec_helper.rb

GeekOnCoffee added a commit to GeekOnCoffee/rspec-core that referenced this issue Jun 3, 2014
GeekOnCoffee added a commit to GeekOnCoffee/rspec-core that referenced this issue Jun 3, 2014
@JonRowe
Copy link
Member

JonRowe commented Jun 3, 2014

(Boo, I like forcing people to fix their warnings :P)

@myronmarston
Copy link
Member Author

(Boo, I like forcing people to fix their warnings :P)

Unfortunately, many gems emit warnings, which can give the user a flood of messages without any indication what they can do to stop seeing them (since they can't change the warning-triggering code).

@JonRowe
Copy link
Member

JonRowe commented Jun 3, 2014

Yeah :/ although it might encourage them to go help fix them :P Or hassle the authors to do so :P

myronmarston added a commit that referenced this issue Jun 3, 2014
Move warnings from .rspec to spec_helper, Fixes #1571
@myronmarston
Copy link
Member Author

...or it might encourage users to not use RSpec when they can't figure out why they are getting so many warnings...

@jondlm
Copy link

jondlm commented Jul 29, 2014

This was definitely disturbing to me as a new rspec user. It didn't make me leave, but it definitely made me think I was doing something complete wrong. 👍

potomak added a commit to potomak/random-colors that referenced this issue Aug 15, 2014
varyonic added a commit to varyonic/demo.activeadmin.info that referenced this issue Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants