-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rspec --init
so that it enables warnings in commented out spec_helper
rather than in .rspec
#1571
Comments
Awesome. took a brief look to see if I could quickly figure out where this was happening, with little success... if nobody else gets to it, I'll try and dig in when I get a chance. |
Basically, we just need to remove this line:
...and add |
(Boo, I like forcing people to fix their warnings :P) |
Unfortunately, many gems emit warnings, which can give the user a flood of messages without any indication what they can do to stop seeing them (since they can't change the warning-triggering code). |
Yeah :/ although it might encourage them to go help fix them :P Or hassle the authors to do so :P |
Move warnings from .rspec to spec_helper, Fixes #1571
...or it might encourage users to not use RSpec when they can't figure out why they are getting so many warnings... |
This was definitely disturbing to me as a new rspec user. It didn't make me leave, but it definitely made me think I was doing something complete wrong. 👍 |
...from a twitter conversation:
https://twitter.com/myronmarston/status/473646079280300032
The text was updated successfully, but these errors were encountered: