Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more evals #1097

Merged
merged 7 commits into from
Oct 4, 2013
Merged

Remove more evals #1097

merged 7 commits into from
Oct 4, 2013

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Oct 4, 2013

Remove more evals uncovered in #862, one of these is contentious.

@JonRowe
Copy link
Member Author

JonRowe commented Oct 4, 2013

/cc @myronmarston

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0%) when pulling cbe9ec8 on remove_more_evals into edb854d on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+14.6%) when pulling f8d73a4 on remove_more_evals into edb854d on master.

myronmarston
myronmarston reviewed Oct 4, 2013
View reviewed changes
spec/rspec/core/formatters/json_formatter_spec.rb
%w(duration example_count failure_count pending_count).each do |key|
expect(summary[key.to_sym]).to eq eval(key)
values.each do |key,value|
expect(summary[key]).to eq value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, removes the eval.

@coveralls
Copy link

Coverage Status

Coverage increased (+14.57%) when pulling 51d6eae on remove_more_evals into edb854d on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+14.6%) when pulling 467fbfc on remove_more_evals into edb854d on master.

myronmarston added a commit that referenced this pull request Oct 4, 2013
@myronmarston
Merge pull request #1097 from rspec/remove_more_evals
b9293ae 
Remove more evals
@myronmarston myronmarston merged commit b9293ae into master Oct 4, 2013
@myronmarston myronmarston deleted the remove_more_evals branch October 4, 2013 05:56
@myronmarston
Copy link
Member

Thanks, @JonRowe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonRowe @coveralls @myronmarston