Don't extend exception #1106
Merged
Don't extend exception #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now write directly to execution_result. Previously we'd overload the actual exception object with this flag. Apart from reducing complexity, this fixes a bug with frozen error objects that failed to extend for obvious reasons. Fixes #1103
|
Haven't yet been able to reproduce the jruby-19mode failure locally, running |
|
Restarted JRuby travis build (cause it's most likely a Heisenbug) |
|
Yep, Heisenbug. |
|
Seems good to me. |
|
LGTM to me as well. It needs a changelog entry, and this needs to be cherry-picked over to 2-99-maintenance and master as well (this is targetting 2-14-maintenance). |
JonRowe
added a commit
that referenced
this pull request
Oct 8, 2013
Don't extend exception Conflicts: Changelog.md lib/rspec/core/pending.rb
|
Thanks @lgierth, I added a changelog entry, and I've picked this across to 2-99 and master. |
JonRowe
added a commit
that referenced
this pull request
Oct 8, 2013
Don't extend exception Conflicts: Changelog.md lib/rspec/core/pending.rb
ghost
deleted the
|
Thanks for the feedback and getting this pulled in so quickly! |
myronmarston
added a commit
that referenced
this pull request
Oct 29, 2013
In https://github.com/tpope/fivemat/blob/v1.2.1/lib/fivemat/rspec.rb#L43-L49, Fivemat has two ways to check for pending example fixed: - example.execution_result[:exception].pending_fixed? (but we removed this in #1106 because it broke when dealing with frozen exceptions) - RSpec::Core::PendingExampleFixedError === exception (but this const was renamed in b5d10cc). The `RSpec::Core::PendingExampleFixedError` line in Fivemat was never hit in recent releases because `example.execution_result[:exception]` responded to `pending_fixed?` -- until 2.14.6.
myronmarston
added a commit
that referenced
this pull request
Oct 30, 2013
In https://github.com/tpope/fivemat/blob/v1.2.1/lib/fivemat/rspec.rb#L43-L49, Fivemat has two ways to check for pending example fixed: - example.execution_result[:exception].pending_fixed? (but we removed this in #1106 because it broke when dealing with frozen exceptions) - RSpec::Core::PendingExampleFixedError === exception (but this const was renamed in b5d10cc). The `RSpec::Core::PendingExampleFixedError` line in Fivemat was never hit in recent releases because `example.execution_result[:exception]` responded to `pending_fixed?` -- until 2.14.6.
This was referenced Dec 13, 2013
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…end-exception Don't extend exception Conflicts: Changelog.md lib/rspec/core/pending.rb --- This commit was imported from rspec/rspec-core@e5b18b7.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
In https://github.com/tpope/fivemat/blob/v1.2.1/lib/fivemat/rspec.rb#L43-L49, Fivemat has two ways to check for pending example fixed: - example.execution_result[:exception].pending_fixed? (but we removed this in rspec/rspec-core#1106 because it broke when dealing with frozen exceptions) - RSpec::Core::PendingExampleFixedError === exception (but this const was renamed in b5d10ccbe3a590adc67d807acb565be3657e51bf). The `RSpec::Core::PendingExampleFixedError` line in Fivemat was never hit in recent releases because `example.execution_result[:exception]` responded to `pending_fixed?` -- until 2.14.6. --- This commit was imported from rspec/rspec-core@35850da.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…end-exception Don't extend exception --- This commit was imported from rspec/rspec-core@a0bf23a.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
In https://github.com/tpope/fivemat/blob/v1.2.1/lib/fivemat/rspec.rb#L43-L49, Fivemat has two ways to check for pending example fixed: - example.execution_result[:exception].pending_fixed? (but we removed this in rspec/rspec-core#1106 because it broke when dealing with frozen exceptions) - RSpec::Core::PendingExampleFixedError === exception (but this const was renamed in b5d10ccbe3a590adc67d807acb565be3657e51bf). The `RSpec::Core::PendingExampleFixedError` line in Fivemat was never hit in recent releases because `example.execution_result[:exception]` responded to `pending_fixed?` -- until 2.14.6. --- This commit was imported from rspec/rspec-core@e2bae1c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now write directly to execution_result. Previously we'd
overload the actual exception object with this flag.
Apart from reducing complexity, this fixes a bug with
frozen error objects that failed to extend for obvious
reasons.
Fixes #1103