Use warnings from rspec-support #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| $LOAD_PATH.unshift(File.expand_path("../../lib", __FILE__)) | |||
|
|
|||
| require 'benchmark' | |||
| require 'rspec/caller_filter' | |||
| require 'rspec/support/caller_filter' | |||
There was a problem hiding this comment.
I think this benchmark should be moved to rspec-support.
|
I have some concerns about moving the bits that depend on rspec-core APIs (e.g. the deprecation formatter) into rspec-support: |
|
See rspec/rspec-support#7 for discussion on that... |
| @@ -25,6 +25,12 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.required_ruby_version = '>= 1.8.7' | |||
|
|
|||
| if RSpec::Core::Version::STRING =~ /[a-zA-Z]+/ | |||
This was referenced Oct 21, 2013
|
Updated in light of rspec/rspec-support#7 |
|
Anyone had a chance to review? /cc @myronmarston @xaviershay |
|
LGTM! |
myronmarston
added a commit
that referenced
this pull request
Oct 30, 2013
Use warnings from rspec-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch over warnings and caller filter to rspec-support