Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit subject fixes #1403

Merged
merged 4 commits into from
Mar 17, 2014
Merged

Implicit subject fixes #1403

merged 4 commits into from
Mar 17, 2014

Commits on Mar 16, 2014

  1. Do not allow described_class to be wrongly overridden to be nil.

    @myronmarston
    myronmarston committed Mar 16, 2014
    Configuration menu
    Copy the full SHA
    abb3328 View commit details
    Browse the repository at this point in the history

  2. Stop passing only metadata. 

    `describe some_hash` should make the `subject`
the hash rather than treating it as metadata.
Metadata comes after the description or described
object.

This needs a 2.99 deprecation.
    @myronmarston
    myronmarston committed Mar 16, 2014
    Configuration menu
    Copy the full SHA
    292d442 View commit details
    Browse the repository at this point in the history

  3. Allow hashes and symbols to be used as an implicit subject. 

    Fixes #1240.

This still needs a 2.99 deprecation.
    @myronmarston
    myronmarston committed Mar 16, 2014
    Configuration menu
    Copy the full SHA
    000a5d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2014

  1. Fix 1.8.7 syntax errors. 

    - 1.8.7 doesn't allow defaults for bock args.
- 1.8.7 doesn't allow trailing commas in lists.
    @myronmarston
    myronmarston committed Mar 17, 2014
    Configuration menu
    Copy the full SHA
    d882fd4 View commit details
    Browse the repository at this point in the history