Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full build #260

Closed
wants to merge 2 commits into from
Closed

Full build #260

wants to merge 2 commits into from

Conversation

myronmarston
Copy link
Member

This makes it easy to build against all supported rubies. I'm having issues running things on jruby but I think it's something in my environment that's messed up. I'm getting tons of spec failures on rubinius 1.1.1 so I didn't include it in the list (but you can easily add it once we get it passing). I'm also getting one cuke failures on 1.8.6--the version of flexmock used by a cuke has invalid syntax on 1.8.6.

If you want me to add this for the other repos, let me know. I figured we can start with this, and tweak to your liking before spending the time adding it to the others.

It now works on:

- MRI 1.8.6
- MRI 1.8.7
- MRI 1.9.1
- MRI 1.9.2
- JRuby 1.5.6
- Rubinius 1.1.1
- REE 1.8.7
- script/spec runs specs
- script/cucumber runs cukes
- script/full_build runs both
@dchelimsky
Copy link
Contributor

This falls apart on linecache for me when we get to 1.9.2.

@myronmarston
Copy link
Member Author

Weird. It definitely works for me on 1.9.2.

What error are you getting?

@dchelimsky
Copy link
Contributor

Installing linecache (0.43) with native extensions /Users/dchelimsky/.rvm/rubies/ruby-1.9.1-p378/lib/ruby/site_ruby/1.9.1/rubygems/installer.rb:483:in `rescue in block in build_extensions': ERROR: Failed to build gem native extension. (Gem::Installer::ExtensionBuildError)

/Users/dchelimsky/.rvm/rubies/ruby-1.9.1-p378/bin/ruby extconf.rb 
Can't handle 1.9.x yet
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of
necessary libraries and/or headers.  Check the mkmf.log file for more
details.  You may need configuration options.

Provided configuration options:
    --with-opt-dir
    --without-opt-dir
    --with-opt-include
    --without-opt-include=${opt-dir}/include
    --with-opt-lib
    --without-opt-lib=${opt-dir}/lib
    --with-make-prog
    --without-make-prog
    --srcdir=.
    --curdir
    --ruby=/Users/dchelimsky/.rvm/rubies/ruby-1.9.1-p378/bin/ruby

@myronmarston
Copy link
Member Author

That's very, very strange. Linecache should only install on 1.8, not on 1.9. It's a dependency of ruby-debug. The Gemfile limits ruby-debug to 1.8 and has a dependency on ruby-debug19 for 1.9 (which in turn depends on linecache19).

Can you paste your Gemfile.lock as a gist? I'm wondering if you somehow have another gem listed that depends on linecache and is a dependency on 1.9. For reference, my Gemfile.lock is here.

You might try removing your Gemfile.lock (or renaming it) and re-running bundle install. Also, I'm using bundler 1.0.7--what version are you using?

@dchelimsky
Copy link
Contributor

bundler 1.0.7 and already deleted Gemfile.lock and bundled again. Will follow up tonight with more info.

@myronmarston
Copy link
Member Author

Add scripts that run specs/cukes against all supported rubies.

  • script/spec runs specs
  • script/cucumber runs cukes
  • script/full_build runs both

Also update Gemfile so it can be used cleanly on lots of rubies.

It now works on:

  • MRI 1.8.6
  • MRI 1.8.7
  • MRI 1.9.1
  • MRI 1.9.2
  • JRuby 1.5.6
  • Rubinius 1.1.1
  • REE 1.8.7
  • Closed by f76caf3

timcharper pushed a commit to timcharper/rspec-core that referenced this pull request Aug 19, 2011
- script/spec runs specs
- script/cucumber runs cukes
- script/full_build runs both

Also update Gemfile so it can be used cleanly on lots of rubies.

It now works on:

- MRI 1.8.6
- MRI 1.8.7
- MRI 1.9.1
- MRI 1.9.2
- JRuby 1.5.6
- Rubinius 1.1.1
- REE 1.8.7

- Closes rspec#260
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants