Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change last should #375

Merged
merged 3 commits into from
Dec 3, 2013
Merged

Change last should #375

merged 3 commits into from
Dec 3, 2013
+35 −12

Conversation

myronmarston
Copy link
Member

This is a follow on from #373.

@myronmarston
Refactor: last_should => last_expectation_handler.
12fa351 
This is more polymorphic and removes `last_should`
from the API (which doesn't really belong anymore).
@myronmarston
Prefer expect-based syntax.
ab8a5af
@myronmarston
Correct reference to deprecated protocol.
480fd82
@JonRowe
Copy link
Member

JonRowe commented Dec 3, 2013

LGTM

myronmarston added a commit that referenced this pull request Dec 3, 2013
@myronmarston
Merge pull request #375 from rspec/change-last-should
df029f0 
Change last should
@myronmarston myronmarston merged commit df029f0 into master Dec 3, 2013
@myronmarston myronmarston deleted the change-last-should branch December 3, 2013 16:06
@yujinakayama yujinakayama mentioned this pull request Dec 4, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@myronmarston @JonRowe