Some general cleanup #389
Merged
Some general cleanup #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the only place where it's used and it belongs here.
| @@ -237,7 +237,7 @@ def o.send(*args); raise "DOH! Library developers shouldn't use #send!" end | |||
| o.should == o | |||
| }.not_to raise_error | |||
| end | |||
| end | |||
| end if false | |||
There was a problem hiding this comment.
Why are these here? Surely this prevents the spec running?
There was a problem hiding this comment.
Good catch. I meant this to be temporary while I was shuffling things around and renamed a couple constants. I pushed a fix.
|
Mostly just code shuffling right? I have one query about some |
Lazy loading it with autoloading is nice since it won't be even be used when folks use only the `expect` syntax.
Given we are recommending the use of `expect` in RSpec 3, no need to include `should` in error messages.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.