Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Some general cleanup #389

Merged
merged 8 commits into from Dec 14, 2013

Conversation

Projects
None yet
2 participants
Owner

myronmarston commented Dec 14, 2013

No description provided.

@JonRowe JonRowe and 1 other commented on an outdated diff Dec 14, 2013

spec/rspec/matchers/built_in/operators_spec.rb
@@ -237,7 +237,7 @@ def o.send(*args); raise "DOH! Library developers shouldn't use #send!" end
o.should == o
}.not_to raise_error
end
- end
+ end if false
@JonRowe

JonRowe Dec 14, 2013

Owner

Why are these here? Surely this prevents the spec running?

@myronmarston

myronmarston Dec 14, 2013

Owner

Good catch. I meant this to be temporary while I was shuffling things around and renamed a couple constants. I pushed a fix.

Owner

JonRowe commented Dec 14, 2013

Mostly just code shuffling right? I have one query about some if falses but otherwise LGTM

myronmarston added some commits Dec 14, 2013

Move operator matchers into `built_in` directory.
Lazy loading it with autoloading is nice since
it won't be even be used when folks use only
the `expect` syntax.
Remove expression generator logic.
Given we are recommending the use of `expect`
in RSpec 3, no need to include `should` in
error messages.

myronmarston added a commit that referenced this pull request Dec 14, 2013

@myronmarston myronmarston merged commit ccdb666 into master Dec 14, 2013

1 check passed

default The Travis CI build passed
Details

@myronmarston myronmarston deleted the some-general-cleanup branch Dec 14, 2013

@myronmarston myronmarston referenced this pull request Dec 14, 2013

Merged

Deprecate constant. #390

myronmarston added a commit that referenced this pull request Dec 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment