Cleanup matcher_execution_context. #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I found a few more things to remove to reduce the API surface area. Anyone want to review this? |
* The external @matcher_execution_context (from `self` at the point the matcher method was called) was odd, and turns out never to have been needed. It was introduced in abba439 but wasn't actually needed there (as the spec added in that commit passed when I tried removing it). * Given that it must be set (as `respond_to?` assumes it has been set), it was odd to have an extra attribute that gets set after instantiation. Far better to make it a constructor arg. * No need to expose it as public method.
Merged
It's nearly identical to `to_sentence`.
It's unnecessary and has some odd coupling, where it assumes the including class has an `expected` attribute. I prefer the simplicity of `to_sentence expected`.
|
LGTM |
myronmarston
added a commit
that referenced
this pull request
Mar 2, 2014
Cleanup matcher_execution_context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selfat the point the matcher method was called) was odd,
and turns out never to have been needed. It was
introduced in abba439
but wasn't actually needed there (as the spec added
in that commit passed when I tried removing it).
respond_to?assumesit has been set), it was odd to have an extra
attribute that gets set after instantiation.
Far better to make it a constructor arg.
This needs a 2.99 PR to deprecate the attribute before being merged.