Prevent infinite ranges blowing up matcher descriptions #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rescue IOError # STDOUT is enumerable but `map` raises an error | ||
| # STDOUT is enumerable but `map` raises an error | ||
| # Range is enumerable except when infinite | ||
| rescue IOError, TypeError |
There was a problem hiding this comment.
Instead of rescueing TypeError, should we consider changing the definition of enumerable? so that ranges aren't enumerated? After all, even for an enumerable range (e.g. all ints: 1..10), I don't think we want it enumerated in the description. We'd rather just have it inspected and displayed as 1..10, right?
If we go that route, we should perhaps rename enumerable? to should_enumerate? or something.
|
Updated |
| }.to fail_with(infinite_range.inspect) | ||
| end | ||
|
|
||
| it "doesnt enumerate normal ranges" do |
|
LGTM. Do you plan to backport this to 3.2? |
|
Travis doesnt like whatever I did, reopening PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent infinite ranges blowing up matcher descriptions, like IO it seems they're not always enumerable. Fixes #754.