Add necessary requires to run the project initializer

[fables-tales]

No description provided.

[fables-tales]

So.... The rails install generator failed because these requires weren't present (I reproduced the issue in my own local rails setup). I couldn't find any tests over this generator. Either I'm being obtuse, or we've got some missing coverage here. Does anyone have any thoughts?

[JonRowe]

Add some? :)

[fables-tales]

@JonRowe I wanted to ask first to make sure I wasn't missing that there were some. Also, not sure what the best way to do this is. It roughly needs to go like this: make a new rails up, add the gem, run the initializer. Should that be in a spec, or a cuke? How should it get run? Where should it put the rails app?

[JonRowe]

(ping @cupakromer)

[cupakromer]

The specs are part of the cukes. However, it seems that b/c this repo already has rspec-support installed as part of it, when that command is run rspec-support is already available 😬

[fables-tales]

In order to actually test this we need to do a shell invocation of creating a new rails app, modifying the Gemfile and then running the install generator. This could all be done by a CLI Cuke.

[cupakromer]

@samphippen I believe that is already part of the cuke process. It creates a new rails app in tmp/example_app runs the generators and then uses that for the remainder of the cukes:

• https://github.com/rspec/rspec-rails/blob/master/features/support/env.rb#L16
• https://github.com/rspec/rspec-rails/blob/master/Rakefile#L49
• https://github.com/rspec/rspec-rails/blob/master/Rakefile#L75

[cupakromer]

However, I see part of the problem. When it generates the app it skips creating the Gemfile. It appears to continue to use the base repos Gemfile.

[cupakromer]

@samphippen If this is going to be an issue, why keep this line: RSpec::Support.require_rspec_core "project_initializer"? Why not just put the full require in: require 'rspec/core/project_initializer'? That would have prevented all this. :(

[myronmarston]

Since this is broken, maybe we should merge and I can release 3.0.1 with this and then we can figure out the missing test coverage after that?

[fables-tales]

@myronmarston I've nearly got a bash script running which reproduces the failure every time, locally. I think merging this now and then adding coverage later is better.

[morgoth]

I have the same issue.

Additionally output of rails generate is missing rspec:install:

bin/rails generate --help
...
Rspec:
  rspec:feature
  rspec:observer

...

[myronmarston]

rspec-rails 3.0.1 has been released with this fix.

[cupakromer]

Thanks @myronmarston!!!!!!