Don't use Rake v11 with older rubies #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See how we've done this on rspec/rspec-core#2200 |
It doesn't work with Ruby 1.8.7 and 1.9.2.
bquorning
force-pushed
the
use-older-rake
branch
from
2fae447
to
93e5157
Compare
|
Thank you @JonRowe. I’ve updated the code. |
|
Seems the root cause is due to rake 11 |
|
This gem doesn’t use |
|
@bquorning Sorry miss leading, I just found the exactly PR of rspec-core, I means since the rspec-core master will support rake 11, so no need here to constraint to using rake 10 only. |
|
Rake v11 doesn’t work with Ruby 1.8.7 and 1.9.2. This PR allows newer versions of Ruby to use the new Rake, while these two older Rubies are limited to the older, compatible version of Rake. |
|
@bquorning you are right, I miss leading again 😄 |
|
No problem :-) |
|
Ready to review/merge. |
Merged
JonRowe
added a commit
that referenced
this pull request
Mar 10, 2016
Don't use Rake v11 with older rubies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't work with Ruby 1.8.7 and 1.9.2.
The latest master build has 8 jobs failing because of the new release of Rake. And it’s hard to work on pull requests when you can’t get a green build :-)