Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rocket hash #2212

Closed
wants to merge 3 commits into from
Closed

Update rocket hash #2212

wants to merge 3 commits into from

Conversation

hmtanbir
Copy link
Contributor

@hmtanbir hmtanbir commented Nov 22, 2019

Use latest rocket hash, removing old rocket hash from routing spec template.
Previous: #2198

@hmtanbir hmtanbir requested a review from pirj November 30, 2019 19:19
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some missing pieces I could quickly find in the generators.

lib/generators/rspec/mailer/mailer_generator.rb
8: argument :actions, :type => :array, :default => [], :banner => "method method"

lib/generators/rspec/integration/integration_generator.rb
10: :type => :boolean,
11: :default => true,
12: :desc => "Generate request specs"

lib/generators/rspec/install/install_generator.rb
35: :destination => tmpdir,
36: :report_stream => StringIO.new
50: :verbose => false
59: :verbose => false

lib/generators/rspec/controller/controller_generator.rb
7: argument :actions, :type => :array, :default => [], :banner => "action action"
9: class_option :template_engine, :desc => "Template engine to generate view files"
10: class_option :controller_specs, :type => :boolean, :default => true, :desc => "Generate controller specs"
11: class_option :view_specs, :type => :boolean, :default => true, :desc => "Generate view specs"
12: class_option :routing_specs, :type => :boolean, :default => false, :desc => "Generate routing specs"

lib/generators/rspec/model/model_generator.rb
8: :type => :array,
9: :default => [],
10: :banner => "field:type field:type"
11: class_option :fixture, :type => :boolean

lib/generators/rspec/system/system_generator.rb
8: class_option :system_specs, :type => :boolean, :default => true, :desc => "Generate system specs"

lib/generators/rspec/view/view_generator.rb
7: argument :actions, :type => :array, :default => [], :banner => "action action"
9: class_option :template_engine, :desc => "Template engine to generate view files"

lib/generators/rspec/generators/generator_generator.rb
7: class_option :generator_specs, :type => :boolean, :default => false, :desc => "Generate generator specs"

lib/generators/rspec/feature/feature_generator.rb
7: class_option :feature_specs, :type => :boolean, :default => true, :desc => "Generate feature specs"
8: class_option :singularize, :type => :boolean, :default => false, :desc => "Singularize the generated feature"

lib/generators/rspec/helper/helper_generator.rb
7: class_option :helper_specs, :type => :boolean, :default => true

lib/generators/rspec/controller/templates/routing_spec.rb
8: expect(:get => "/<%= class_name.underscore %>/<%= action %>").to route_to("<%= class_name.underscore %>#<%= action %>")

lib/generators/rspec/scaffold/templates/show_spec.rb
8: :<%= attribute.name %> => <%= value_for(attribute) %><%= attribute_index == output_attributes.length - 1 ? '' : ','%>

lib/generators/rspec/scaffold/templates/edit_spec.rb
8: :<%= attribute.name %> => <%= attribute.default.inspect %><%= attribute_index == output_attributes.length - 1 ? '' : ','%>

lib/generators/rspec/scaffold/templates/api_controller_spec.rb
63: get :show, {:id => <%= file_name %>.to_param}, valid_session
76: post :create, {:<%= ns_file_name %> => valid_attributes}, valid_session
85: post :create, {:<%= ns_file_name %> => valid_attributes}, valid_session
98: post :create, {:<%= ns_file_name %> => invalid_attributes}, valid_session
117: put :update, {:id => <%= file_name %>.to_param, :<%= ns_file_name %> => new_attributes}, valid_session
128: put :update, {:id => <%= file_name %>.to_param, :<%= ns_file_name %> => valid_attributes}, valid_session
141: put :update, {:id => <%= file_name %>.to_param, :<%= ns_file_name %> => invalid_attributes}, valid_session
156: delete :destroy, {:id => <%= file_name %>.to_param}, valid_session

lib/generators/rspec/scaffold/templates/controller_spec.rb
63: get :show, {:id => <%= file_name %>.to_param}, valid_session
86: get :edit, {:id => <%= file_name %>.to_param}, valid_session
99: post :create, {:<%= ns_file_name %> => valid_attributes}, valid_session
108: post :create, {:<%= ns_file_name %> => valid_attributes}, valid_session
119: post :create, {:<%= ns_file_name %> => invalid_attributes}, valid_session
137: put :update, {:id => <%= file_name %>.to_param, :<%= ns_file_name %> => new_attributes}, valid_session
148: put :update, {:id => <%= file_name %>.to_param, :<%= ns_file_name %> => valid_attributes}, valid_session
160: put :update, {:id => <%= file_name %>.to_param, :<%= ns_file_name %> => invalid_attributes}, valid_session
174: delete :destroy, {:id => <%= file_name %>.to_param}, valid_session
184: delete :destroy, {:id => <%= file_name %>.to_param}, valid_session

lib/generators/rspec/scaffold/templates/new_spec.rb
8: :<%= attribute.name %> => <%= attribute.default.inspect %><%= attribute_index == output_attributes.length - 1 ? '' : ','%>

lib/generators/rspec/install/templates/spec/rails_helper.rb
66: # RSpec.describe UsersController, :type => :controller do

lib/generators/rspec/scaffold/templates/index_spec.rb
10: :<%= attribute.name %> => <%= value_for(attribute) %><%= attribute_index == output_attributes.length - 1 ? '' : ','%>
22: assert_select "tr>td", :text => <%= value_for(attribute) %>.to_s, :count => 2

.rubocop.yml Show resolved Hide resolved
@JonRowe
Copy link
Member

JonRowe commented Dec 6, 2019

Can you rebase this? We updated master to have the latest rubocop.

@hmtanbir
Copy link
Contributor Author

hmtanbir commented Dec 7, 2019

OK, I will rebase.

@hmtanbir hmtanbir closed this Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants