Update rocket hash #2224
Merged
Update rocket hash #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmtanbir
force-pushed
the
update-rocket-hash
branch
2 times, most recently
from
62fedf1
to
f2fd202
Compare
|
@pirj Would you please check this PR ? |
pirj
approved these changes
Dec 8, 2019
.rubocop_todo.yml
Outdated
| @@ -20,7 +20,7 @@ Style/EachWithObject: | |||
|
|
|||
| # ruby 1.8.7 only had support for hash rockets | |||
| Style/HashSyntax: | |||
| EnforcedStyle: hash_rockets # default: ruby19 | |||
| EnforcedStyle: ruby19 # default: ruby19 | |||
There was a problem hiding this comment.
You may freely remove this setting since it's the default.
|
@hmtanbir Please squash commits. Thanks for the effort! |
hmtanbir
force-pushed
the
update-rocket-hash
branch
from
3fefe73
to
4f4d3f5
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved feeback.
Previous: #2212