Pin RuboCop to avoid failures due to renamed cops #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RuboCop 1.0 this will stop happening, and we'll be able to relax it
to:
gem 'rubocop', '~> 1.0'
Closed
JonRowe
reviewed
Dec 2, 2019
JonRowe
requested changes
Dec 4, 2019
|
|
|
@JonRowe The build is green. |
JonRowe
reviewed
Dec 5, 2019
JonRowe
reviewed
Dec 5, 2019
[skip ci]
JonRowe
approved these changes
Dec 5, 2019
|
Looks good, I'm going to merge this so we can fix builds etc. Comments are for conversation only, I also added back an explanation for a rule. |
JonRowe
added a commit
that referenced
this pull request
Jan 12, 2020
Pin RuboCop to avoid failures due to renamed cops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RuboCop 1.0 this will stop happening, and we'll be able to relax it to:
Caused trouble in #2215 and #2212