Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent sprocket install failure when we are using Ruby below 2.5 #2347

Closed
wants to merge 1 commit into from
Closed

Prevent sprocket install failure when we are using Ruby below 2.5 #2347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ end

gem "rubyzip", '~> 1.2'

if RUBY_VERSION.to_f < 2.5
gem 'sprockets', '~> 3.7.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't Bundler figure it out on its own? They do specify a version:

  s.required_ruby_version = '>= 2.5.0'

shouldn't bundle take this into account and check out sprockets < 4.0 when it understands that 4+ won't work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This what I thought but the CI failed earlier for this PR #2346. But I am not able to find it again. It was on Ruby 2.4.

I will close it for now. We will see if it happen again.

end

if RUBY_VERSION.to_f >= 2.3
gem 'rubocop', '~> 0.80.1'
end
Expand Down