Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezones #49

Closed
ok11 opened this issue May 14, 2023 · 22 comments
Closed

Timezones #49

ok11 opened this issue May 14, 2023 · 22 comments
Labels
enhancement New feature or request

Comments

@ok11
Copy link

ok11 commented May 14, 2023

Hey! There are timezones not considered in the index.js, e.g. "Europe/Berlin" (that's where I am ;)). Is definitely not a pressing issue though. I could add some and open a PR if you want, would take less important work from you 😀

Thanks!

@rstrouse
Copy link
Owner

Is the posix code for Europe/Berlin CET-1CEST,M3.5.0,M10.5.0/3?

@ok11
Copy link
Author

ok11 commented May 14, 2023

CEST-1CET,M3.2.0/2:00:00,M11.1.0/2:00:00

@rstrouse
Copy link
Owner

Thanks I added it to the tz list and will come in the next release that I will post this week.

@rstrouse
Copy link
Owner

v1.6.0 now supports the Europe/Berlin timezone.

@cesarvoggithub
Copy link

Could you please also add America/Sao_Paulo (Etc/GMT-3)?

TIA

@rstrouse
Copy link
Owner

It will show up on the next release. Btw the posix code for the timezone is <-03>3

@cesarvoggithub
Copy link

cesarvoggithub commented May 19, 2023 via email

@rstrouse
Copy link
Owner

Update to v1.6.1 I added the Sao Paulo timezone.

@cesarvoggithub
Copy link

Thanks for the update. I'm afraid the Application is still 1.6.0. I first tried updating by uploading the firmware first (worked as the frmware "took" and changed to 1.6.1) and then the application (did not "take" as it remained 1.6.0). Then I decided I would start from scratch by reloading the original ESPhome firmware (worked as everything went back to default) and then by installing the newonboard file (worked, but firmware showed 1.6.1 and application remained 1.6.0). And since the application did not "take", America/Sao_Paulo is still not an available choice in the dropdown list.

@cesarvoggithub
Copy link

Scratch the above. I tried re-downloading the SomfyController.littlefs.bin file and this time it worked!

@rstrouse
Copy link
Owner

Unfortunately you probably caught it before I changed the release token. A hard refresh of the browser would have fixed the issue. I am doing some browser tricks to clear the cache on for the app and unfortunately I missed one spot on the release files earlier.

@pfak
Copy link

pfak commented May 24, 2023

America/Vancouver is also missing.

@rstrouse
Copy link
Owner

America/Vancouver is the same timezone alias as America/Los_Angeles.

@getselim-stack
Copy link

Can you please add Asia/Dubai UTC+4 (no daylight saving)?

@rstrouse
Copy link
Owner

That is the same timezone as Asia/Baku posix: <+4>-4. The reason I am not duplicating the them is that this is one of the more costly string arrays in terms of storage and transfer in the software. However, please keep them coming and I will let you know if there is a setting already in the same ntp timezone.

Unfortunately, I am not smart enough to gather which duplicates are the more logical selection.

@getselim-stack
Copy link

That is the same timezone as Asia/Baku posix: <+4>-4. The reason I am not duplicating the them is that this is one of the more costly string arrays in terms of storage and transfer in the software. However, please keep them coming and I will let you know if there is a setting already in the same ntp timezone.

Unfortunately, I am not smart enough to gather which duplicates are the more logical selection.

Cool - I did spend an hour looking at options before posting, honest. Appreciate the quick response and the great work - this is the third option I've tried to automate my Somfy and it worked like a charm. Not willing to pay the $230 Somfy want for their bridge for something that contains $20 worth of hardware!

@pfak
Copy link

pfak commented May 26, 2023

@rstrouse

Instead of for example America/Los_Angeles, you could use US/Pacific etc:

/usr/share/zoneinfo/posix/US$ ls -lt
total 0
lrwxrwxrwx 1 root root 20 Apr  3 04:12 Alaska -> ../America/Anchorage
lrwxrwxrwx 1 root root 15 Apr  3 04:12 Aleutian -> ../America/Adak
lrwxrwxrwx 1 root root 18 Apr  3 04:12 Arizona -> ../America/Phoenix
lrwxrwxrwx 1 root root 18 Apr  3 04:12 Central -> ../America/Chicago
lrwxrwxrwx 1 root root 19 Apr  3 04:12 Eastern -> ../America/New_York
lrwxrwxrwx 1 root root 31 Apr  3 04:12 East-Indiana -> ../America/Indiana/Indianapolis
lrwxrwxrwx 1 root root 19 Apr  3 04:12 Hawaii -> ../Pacific/Honolulu
lrwxrwxrwx 1 root root 23 Apr  3 04:12 Indiana-Starke -> ../America/Indiana/Knox
lrwxrwxrwx 1 root root 18 Apr  3 04:12 Michigan -> ../America/Detroit
lrwxrwxrwx 1 root root 17 Apr  3 04:12 Mountain -> ../America/Denver
lrwxrwxrwx 1 root root 22 Apr  3 04:12 Pacific -> ../America/Los_Angeles
lrwxrwxrwx 1 root root 20 Apr  3 04:12 Samoa -> ../Pacific/Pago_Pago

@pfak
Copy link

pfak commented May 26, 2023

OR (preferably) where there is overlap, i.e. US and Canada, you could do "Pacific", "Central", "Eastern", etc.

@getselim-stack
Copy link

OR (preferably) where there is overlap, i.e. US and Canada, you could do "Pacific", "Central", "Eastern", etc.

Good idea. Generic time zones would be a good approach as I appreciate the need to keep it as light as possible. Happy to help define for this region if needed.

@rstrouse
Copy link
Owner

Yeah the entire posix database is around 500 entries. To make sure we get valid log times it seemed pretty expensive to use the whole thing. Below is a link to one of the myriad of databases for them. I probably should have started with the Etc/GMT+- and eliminated those first. I am keying on the code (right hand column) and not the city for that very reason.

You may be surprised at how weird all of this DST stuff is when trying to keep track of the 4th dimension. I'll take a stab at reworking tags to generalize them.

https://github.com/nayarsystems/posix_tz_db/blob/master/zones.csv

Not willing to pay the $230 Somfy want for their bridge for something that contains $20 worth of hardware!

To add to that I don't want any more cloud stuff in my house. 10 years from now folks are going to look around at their home automation battlefield to see many soldiers that worked for a couple of years but couldn't keep up the fight. Imagine the carnage and blown out rusted relics littering the scene.

@rstrouse
Copy link
Owner

The new time zone data will be posted in v1.7.1 in the next couple of days.

@rstrouse rstrouse added the enhancement New feature or request label Jun 17, 2023
@rstrouse
Copy link
Owner

v1.7.1 has been released with the timezone changes discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants