add_attachment supports multiple files #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderv
approved these changes
May 2, 2023
| @@ -1,3 +1,7 @@ | |||
| # blastula 0.3.3 | |||
There was a problem hiding this comment.
I believe it should be 0.3.4 now or any other header for development version now that 0.3.3 has been release
There was a problem hiding this comment.
@rich-iannone you may want to consider to use withr for your tests - it is really useful for such usage when needing to create temp file. Everything will be cleaned up after each tests when using withr::local_tempfile() for example.
Quite a good helper package, which is install with testthat so available in testthat suits of tests.
There was a problem hiding this comment.
I like this idea very much! I've been a bit slow to adopt withr but I do think I should take advantage of its functions that help with testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #239