Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_attachment() should support multiple files at once #239

Open
shrektan opened this issue Nov 28, 2020 · 0 comments · May be fixed by #240
Open

add_attachment() should support multiple files at once #239

shrektan opened this issue Nov 28, 2020 · 0 comments · May be fixed by #240

Comments

@shrektan
Copy link
Contributor

This example code should explains what I mean well:

library(blastula)
files <- c(tempfile(fileext = ".txt"), tempfile(fileext = ".txt"))
writeLines("file1", files[1])
writeLines("file2", files[2])
email <- compose_email("test")
out1 <- add_attachment(email, files)$attachments
out2 <- local({
  email <- add_attachment(email, files[1])
  email <- add_attachment(email, files[2])
  email$attachments
})

out1 and out2 should generate the same result. However, at present, smtp_send() will fail when out1 is used for the email argument.

@shrektan shrektan linked a pull request Nov 28, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant