Relax index.Rmd constraint and correctly support edge case
#1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a directory is passed, search for index file and if they do not exists, just don't set an input value. input is just use as fallback for format guessing. Otherwise `sources_files()` is used to know what to render. This should restore better past behavior from discussion in https://community.rstudio.com/t/render-book-error-stop-if-not-exists-and-some-files-were-not-found/139927/24
yihui
approved these changes
Jun 23, 2022
First one found will be used. Only one is expected though
cderv
force-pushed
the
relax-index-constraint
branch
from
6e778b3
to
93f5271
Compare
[skip ci]
cderv
changed the title
index.Rmd constraint and correctly support edge case
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #1349
This PR tries to achieve two things:
index.Rmdandindex.rmdas main file expected in a bookdown projectrender_book("my_file.Rmd")wheremy_file.Rmdplays the role of index file but with another name.I am opening this PR as a draft to get some first feedback @yihui. I also need to check that report in community (https://community.rstudio.com/t/render-book-error-stop-if-not-exists-and-some-files-were-not-found/139927/19) is taken into account.