Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arrange test issues #16

Open
colearendt opened this issue Mar 23, 2018 · 0 comments
Open

Fix arrange test issues #16

colearendt opened this issue Mar 23, 2018 · 0 comments
Labels

Comments

@colearendt
Copy link
Contributor

Relates to #8

When testing arrange, the default behavior is to pull the last column of the data.frame in question (since arrange does not modify columns like a mutate would). This can have problems with testing since the level of uniqueness of the sort is important to test success / failure.

Further, there can be problems with adding mutate() to create the column so the same level of uniqueness is present because

  1. it is not a unit test of arrange
  2. some verbs (like desc(column)) are not valid within mutate

Very tricky... it almost seems we need a "unique value" column like id or something... and then every arrange needs to be done by the computation in question and then by the unique column.

@colearendt colearendt added the bug label Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant