Fix for invisible top borders in rendered HTML tables #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the problem whereby gt tables, when rendered as HTML, have invisible top lines of cell borders (not visible unless
2px
or larger).The problem is isolated to the CSS rules of the
gt_row
class:Substituting all
border-bottom-*
rules forborder-top-*
avoids the line-drawing conflict between row lines and border lines. That is the only change in this PR and, through several visual tests, the changes made here fix the display issue.Fixes: #358.