CSS modifications #346
Merged
CSS modifications #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
approved these changes
Aug 8, 2019
Closed
rich-iannone
added a commit
to batpigandme/gt
that referenced
this pull request
Nov 11, 2019
* master: (59 commits) add fmt_markdown to _pkgdown.yml (rstudio#371) Use `tidy_grepl()` instead of `expect_match()` Use `tidy_grepl()` & `expect_true()` Add `dt_*()` methods for all major, internal data structures (rstudio#355) Update CLA text (rstudio#373) remove reliance on Github version of sass, which is now updated on CRAN (rstudio#366) Fix for invisible top borders in rendered HTML tables (rstudio#359) CSS modifications (rstudio#346) Incorporate alpha option to `cell_fill()` (rstudio#340) Enable option to set row group padding in `tab_options()` (rstudio#342) Modify `filter()` statement (rstudio#341) Allow use of integers in `pct()`/`px()` (rstudio#336) Fix for resolving row group cells (rstudio#335) Easier access to footnote mark options (rstudio#333) Export `as.tags.gt_tbl()` (rstudio#331) Several `rlang`-based fixes (rstudio#334) Add function to specify column widths: `cols_widths()` (rstudio#293) Add `rstudio/sass` to Remotes list (rstudio#326) Fix for `cell_borders()` (rstudio#323) Allow an empty table with zero rows to create an empty gt table (rstudio#283) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes improve (to my eyes, at least) to default appearance of an HTML table. Thin horizontal lines are used for each data row. All thicker lines has their colors lightened (from
#A8A8A8to#D3D3D3) except for the top and bottom table lines. The default text is lightened from#000000to#333333(gray20). This is only slightly noticeable but it has the effect of softening the text somewhat. Padding in the table columns has been reduced and padding between the table Title and Subtitle has been tweaked for better optical positioning.Here are three examples with the new CSS changes.