Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor render_exercise() evalutation of setup code #487

Merged
merged 2 commits into from Feb 3, 2021
Merged

Refactor render_exercise() evalutation of setup code #487

merged 2 commits into from Feb 3, 2021

Conversation

gadenbuie
Copy link
Member

  • Only render first pass if there is prep code to evaluate
  • Clean up exercise_prep.Rmd and its intermediate and output files before evaluating user code
  • Write exercise.Rmd after evaluating setup code
  • Warn in logs if setup code creates an exercise.Rmd
  • Add tests around flow and key assumption

PR task list:

  • Update NEWS
  • Add tests (if possible)
  • Update documentation with devtools::document()

@gadenbuie
Refactor render_exercise() evalutation of setup code
ab72ea0 
- Only render first pass if there is prep code to evaluate
- Clean up exercise_prep.Rmd and its intermediate and output files before evaluating user code
- Write exercise.Rmd _after_ evaluating setup code
- Warn in logs if setup code creates an exercise.Rmd
- Add tests around flow and key assumption
@gadenbuie gadenbuie merged commit 1b45ad6 into rstudio:master Feb 3, 2021
@gadenbuie gadenbuie deleted the garrick/render-prep-if-neeeded branch February 3, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gadenbuie @schloerke