Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor render_exercise() evalutation of setup code #487

Merged
merged 2 commits into from Feb 3, 2021
Merged

Refactor render_exercise() evalutation of setup code #487

merged 2 commits into from Feb 3, 2021

Commits on Feb 3, 2021

  1. Refactor render_exercise() evalutation of setup code 

    - Only render first pass if there is prep code to evaluate
- Clean up exercise_prep.Rmd and its intermediate and output files before evaluating user code
- Write exercise.Rmd _after_ evaluating setup code
- Warn in logs if setup code creates an exercise.Rmd
- Add tests around flow and key assumption
    @gadenbuie
    gadenbuie committed Feb 3, 2021
    Copy the full SHA
    ab72ea0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into garrick/render-prep-if-neeeded

    @gadenbuie
    gadenbuie committed Feb 3, 2021
    Copy the full SHA
    d875824 View commit details
    Browse the repository at this point in the history