test that variables defined after a function may be used within the function #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
reviewed
Nov 2, 2018
wch
reviewed
Nov 2, 2018
|
Test will fail as the current implementation of this branch is faulty. |
schloerke
added a commit
to schloerke/plumber
that referenced
this pull request
Nov 5, 2018
Fixes tests made in rstudio#331
schloerke
added a commit
that referenced
this pull request
Nov 6, 2018
* The source files used in plumber must use the UTF-8 encoding if they contain non-ASCII characters * comments * display appveyor local * try in install script * chinese only * top level scripts only * no cache * use testthat::test_path when providing relative test files * add sourceUTF8 and helper functions from shiny This stems from wanting to read utf8 files on a non utf8 locale. On windows, the locale is set to the system default which typically does not support utf8 out of the box. sourceUTF8 functions are adopted form the rstudio/shiny repo in an effort to use code that has already be validated to work. The ending finding is that `source(file, encoding="UTF-8")` does not work as expected and instead should use `eval(parse(file, encoding = "UTF-8"))` * remove appveyor file as locale / utf8 can be tested on travis * add second PR to news item * add note for why sourcing is done * add note about keeping the source location when parsing * Evalauate all file expression blocks only once, not once or twice Fixes tests made in #331 * activateBlock -> evaluateBlock * add comments about LC_ALL and use charToRaw to test UTF-8 strings * minimize travis crand and github pkg downloads * remove travis comments * added news item about sourcing code only once * bold **must use** * add default appveyor Co-authored-by: Xianying Tan <shrektan@126.com> Co-authored-by: Barret Schloerke <schloerke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for #330