uft8 source file support #328
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…contain non-ASCII characters
This stems from wanting to read utf8 files on a non utf8 locale. On windows, the locale is set to the system default which typically does not support utf8 out of the box. sourceUTF8 functions are adopted form the rstudio/shiny repo in an effort to use code that has already be validated to work. The ending finding is that `source(file, encoding="UTF-8")` does not work as expected and instead should use `eval(parse(file, encoding = "UTF-8"))`
@@ Coverage Diff @@ ## master #328 +/- ## ========================================== - Coverage 90.04% 88.86% -1.19% ========================================== Files 26 27 +1 Lines 1145 1176 +31 ========================================== + Hits 1031 1045 +14 - Misses 114 131 +17
Fixes tests made in rstudio#331
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.