Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure body parsers to use content type. Add many parsers #584

Merged
merged 79 commits into from Jul 31, 2020
Merged

Restructure body parsers to use content type. Add many parsers #584

merged 79 commits into from Jul 31, 2020

Commits on Jul 3, 2020

  1. add check before guessing content-type

    Bruno Tremblay committed Jul 3, 2020
    Copy the full SHA
    2c05be1 View commit details
    Browse the repository at this point in the history

  2. PR suggestion, gitattributes

    Bruno Tremblay committed Jul 3, 2020
    Copy the full SHA
    5c78836 View commit details
    Browse the repository at this point in the history

  3. remove to readd

    Bruno Tremblay committed Jul 3, 2020
    Copy the full SHA
    680bd8e View commit details
    Browse the repository at this point in the history

  4. readd binary

    Bruno Tremblay committed Jul 3, 2020
    Copy the full SHA
    161164e View commit details
    Browse the repository at this point in the history

  5. Add back ... args to safeFromJSON()

    @schloerke
    schloerke committed Jul 3, 2020
    Copy the full SHA
    2954c74 View commit details
    Browse the repository at this point in the history

  6. Adjust parsers to allow for arguments. Use direct matches only 

    * Restructure parser list to use the pattern as the key and parser as the value. Allows the same parser to exist under different content type values.
* Provide duplicate parsers for commonly seen content types
* add tsv parser
* add csv parser
* Allow for arguments to be supplied to parsers
* use other parsers to reduce copy/pasta
    @schloerke
    schloerke committed Jul 3, 2020
    Copy the full SHA
    4233155 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'respect_ctype' of https://github.com/meztez/plumber int… 

    …o post_body_content_type
    @schloerke
    schloerke committed Jul 3, 2020
    Copy the full SHA
    f392e60 View commit details
    Browse the repository at this point in the history

  8. use stringi methods

    @schloerke
    schloerke committed Jul 3, 2020
    Copy the full SHA
    dee07fa View commit details
    Browse the repository at this point in the history

  9. Add comments as to why the content type is being altered

    @schloerke
    schloerke committed Jul 3, 2020
    Copy the full SHA
    0f27683 View commit details
    Browse the repository at this point in the history

  10. Merged name change

    @schloerke
    schloerke committed Jul 3, 2020
    Copy the full SHA
    30ca5ad View commit details
    Browse the repository at this point in the history

  11. Add a default file name in case one isn't provided

    @schloerke
    schloerke committed Jul 3, 2020
    Copy the full SHA
    ddaa3c5 View commit details
    Browse the repository at this point in the history

  12. Add tsv and csv tests. Rename test file.

    @schloerke
    schloerke committed Jul 3, 2020
    Copy the full SHA
    11d459c View commit details
    Browse the repository at this point in the history

  13. add news item

    @schloerke
    schloerke committed Jul 3, 2020
    Copy the full SHA
    48e7809 View commit details
    Browse the repository at this point in the history

  14. fix topic names for pkgdown

    @schloerke
    schloerke committed Jul 3, 2020
    Copy the full SHA
    79c2972 View commit details
    Browse the repository at this point in the history

  15. Add octet-stream

    @schloerke
    schloerke committed Jul 3, 2020
    1
    Copy the full SHA
    10199b5 View commit details
    Browse the repository at this point in the history

  16. Remove invalid content type

    @schloerke
    schloerke committed Jul 3, 2020
    Copy the full SHA
    61fec39 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Do not eval any yaml

    @schloerke
    schloerke committed Jul 7, 2020
    Copy the full SHA
    0d3b795 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. parser plumber tag, parser builder functions return a named list of m… 

    …ime-type = parser
    Bruno Tremblay committed Jul 9, 2020
    Copy the full SHA
    8110b91 View commit details
    Browse the repository at this point in the history

  2. passing current tests

    Bruno Tremblay committed Jul 9, 2020
    Copy the full SHA
    b2c0582 View commit details
    Browse the repository at this point in the history

  3. change default parsers on router

    Bruno Tremblay committed Jul 9, 2020
    Copy the full SHA
    70d3691 View commit details
    Browse the repository at this point in the history

  4. adding @parser none and @parser all, update parsers doc.

    Bruno Tremblay committed Jul 9, 2020
    Copy the full SHA
    bd0a46f View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Add more default parsers

Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @schloerke
    Bruno Tremblay and schloerke committed Jul 9, 2020
    Copy the full SHA
    7aa66f6 View commit details
    Browse the repository at this point in the history

  6. update doc, avoid recursively calling parser_all

    Bruno Tremblay committed Jul 9, 2020
    Copy the full SHA
    0479637 View commit details
    Browse the repository at this point in the history

  7. re-added parser to content-type test

    Bruno Tremblay committed Jul 9, 2020
    Copy the full SHA
    290fbf9 View commit details
    Browse the repository at this point in the history

  8. Adding test for the parser tag

    Bruno Tremblay committed Jul 9, 2020
    Copy the full SHA
    4c578a1 View commit details
    Browse the repository at this point in the history

  9. remerge fix conflict 

    Merge remote-tracking branch 'upstream/post_body_content_type' into post_body_content_type

# Conflicts:
#	R/parse-body.R
    Bruno Tremblay committed Jul 9, 2020
    Copy the full SHA
    0d30e34 View commit details
    Browse the repository at this point in the history

  10. parse_json instead of fromJSON

    Bruno Tremblay committed Jul 9, 2020
    Copy the full SHA
    b5efad4 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. Rework parser matching to also do regex on top of (after) fixed match… 

    … + lower case content-type

Added helper function make_parsers to transform into named list.
Fix order of plumbed parsers to match order in plumbed file.
    Bruno Tremblay committed Jul 10, 2020
    Copy the full SHA
    8955d8f View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. modify make_parsers to handle shortname, fixed and regex for Content-… 

    …Type match
    Bruno Tremblay committed Jul 20, 2020
    Copy the full SHA
    bc0264c View commit details
    Browse the repository at this point in the history

  2. slight change to parser_text reference, use shortname instead of [[1]]

    Bruno Tremblay committed Jul 20, 2020
    Copy the full SHA
    730c4ba View commit details
    Browse the repository at this point in the history

  3. Update R/parse-body.R 

    Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @schloerke
    Bruno Tremblay and schloerke committed Jul 20, 2020
    Copy the full SHA
    6ae2da5 View commit details
    Browse the repository at this point in the history

  4. Update R/parse-body.R 

    Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @schloerke
    Bruno Tremblay and schloerke committed Jul 20, 2020
    Copy the full SHA
    beb12a2 View commit details
    Browse the repository at this point in the history

  5. Update R/parse-body.R 

    Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @schloerke
    Bruno Tremblay and schloerke committed Jul 20, 2020
    Copy the full SHA
    de672af View commit details
    Browse the repository at this point in the history

  6. Update R/parse-body.R 

    Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @schloerke
    Bruno Tremblay and schloerke committed Jul 20, 2020
    Copy the full SHA
    edc2f12 View commit details
    Browse the repository at this point in the history

  7. Update R/parse-body.R 

    Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @schloerke
    Bruno Tremblay and schloerke committed Jul 20, 2020
    Copy the full SHA
    83effa4 View commit details
    Browse the repository at this point in the history

  8. Move make_parsers to add_parser and associated impact fix

    Bruno Tremblay committed Jul 20, 2020
    Copy the full SHA
    cbe8ff9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Merge pull request #587 from meztez/post_body_content_type

    @schloerke
    schloerke committed Jul 21, 2020
    Copy the full SHA
    53efca8 View commit details
    Browse the repository at this point in the history

  2. Make arg required

    @schloerke
    schloerke committed Jul 21, 2020
    Copy the full SHA
    1357e25 View commit details
    Browse the repository at this point in the history

  3. document

    @schloerke
    schloerke committed Jul 21, 2020
    Copy the full SHA
    1b4b0e5 View commit details
    Browse the repository at this point in the history

  4. display value when selecting

    @schloerke
    schloerke committed Jul 21, 2020
    Copy the full SHA
    4023650 View commit details
    Browse the repository at this point in the history

  5. parser_none should ask for no alias values

    @schloerke
    schloerke committed Jul 21, 2020
    Copy the full SHA
    05d680d View commit details
    Browse the repository at this point in the history

  6. have all endpoint parsers run through select_parsers(). Fixes #612

    @schloerke
    schloerke committed Jul 21, 2020
    Copy the full SHA
    e00fd23 View commit details
    Browse the repository at this point in the history

  7. Nitpick

    @cpsievert
    cpsievert committed Jul 21, 2020
    Copy the full SHA
    9236241 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
    @schloerke @cpsievert
    schloerke and cpsievert committed Jul 22, 2020
    Copy the full SHA
    d178b97 View commit details
    Browse the repository at this point in the history

  2. merge master

    @schloerke
    schloerke committed Jul 22, 2020
    Copy the full SHA
    def1bab View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Rename pr private$parsers to private$default_parsers

    @schloerke
    schloerke committed Jul 23, 2020
    Copy the full SHA
    1ae78d4 View commit details
    Browse the repository at this point in the history

  2. Rename add_parser to register_parser. Allow for TRUE, character vect,… 

    … and named list of parser to arguments
    @schloerke
    schloerke committed Jul 23, 2020
    Copy the full SHA
    12fb373 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. get_parsers() -> make_parser(); add_parser() -> `register_parse… 

    …r()`

Allow for many different types of inputs. Which allows for arguments for each particular parser to be passed through.
    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    2b950d2 View commit details
    Browse the repository at this point in the history

  2. plumb block should set up a named list of parser to arguments structu… 

    …re to later be processed by plumber endpoint
    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    7f09915 View commit details
    Browse the repository at this point in the history

  3. Update and add more tests for parsers

    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    779b181 View commit details
    Browse the repository at this point in the history

  4. Fix checks and document

    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    194fd74 View commit details
    Browse the repository at this point in the history

  5. do not document hookable for now

    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    98fd28a View commit details
    Browse the repository at this point in the history

  6. Heavily update the pkgdown order

    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    4a4d97b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into post_body_content_type 

    * master:
  Update Docker files (#589)
    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    72acadd View commit details
    Browse the repository at this point in the history

  8. change name to sample_name

    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    364a8e1 View commit details
    Browse the repository at this point in the history

  9. If have default parsers already be sent through make_parser()

    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    e86ea2e View commit details
    Browse the repository at this point in the history

  10. Remove parser_all from exising and being exported as it is not a _r… 

    …eal_ parser

(plus it didnt' work)
    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    10c3d38 View commit details
    Browse the repository at this point in the history

  11. Require readr within the inner parsing function, not in the outer par… 

    …sing function

Allows for `'all'` to include everything and not throw if one serializer can't meet it's dependency
    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    d503a25 View commit details
    Browse the repository at this point in the history

  12. document and add more tests and fix tests

    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    4efe31b View commit details
    Browse the repository at this point in the history

  13. "remove" addSerializer(). Define register_serializer() and registered… 

    …_serializers()
    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    f8624ed View commit details
    Browse the repository at this point in the history

  14. Fix test

    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    fb3bb70 View commit details
    Browse the repository at this point in the history

  15. Moar docs

    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    c5376d7 View commit details
    Browse the repository at this point in the history

  16. Use local() rather than withr::with_options()

    @schloerke
    schloerke committed Jul 24, 2020
    Copy the full SHA
    2ab37b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. update comments

    @schloerke
    schloerke committed Jul 28, 2020
    Copy the full SHA
    733760d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into post_body_content_type 

    * master:
  Replace plus sign with space character when parsing a query string (#618)
    @schloerke
    schloerke committed Jul 28, 2020
    Copy the full SHA
    c141fa5 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Eval in proper env (related to #620) 

    Co-authored-by: Bruno Tremblay <bruno.tremblay@lacapitale.com>
    @cpsievert
    cpsievert and Bruno Tremblay committed Jul 29, 2020
    Copy the full SHA
    18655f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Forgot to change the docs 

    Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
    @schloerke @cpsievert
    schloerke and cpsievert committed Jul 31, 2020
    Copy the full SHA
    d95325d View commit details
    Browse the repository at this point in the history

  2. Move parser_read_file down in file

    @schloerke
    schloerke committed Jul 31, 2020
    Copy the full SHA
    71b6aa8 View commit details
    Browse the repository at this point in the history

  3. Allow for readr to take original raw value directly

    @schloerke
    schloerke committed Jul 31, 2020
    Copy the full SHA
    1710168 View commit details
    Browse the repository at this point in the history

  4. rename test file to have it be executed last. (it's slow)

    @schloerke
    schloerke committed Jul 31, 2020
    Copy the full SHA
    d4b6339 View commit details
    Browse the repository at this point in the history

  5. merge master

    @schloerke
    schloerke committed Jul 31, 2020
    Copy the full SHA
    8481248 View commit details
    Browse the repository at this point in the history

  6. scope readr parser args properly

    @schloerke
    schloerke committed Jul 31, 2020
    Copy the full SHA
    c6c3a09 View commit details
    Browse the repository at this point in the history

  7. safe guard against temp files possibly being deleted by user

    @schloerke
    schloerke committed Jul 31, 2020
    Copy the full SHA
    538e75a View commit details
    Browse the repository at this point in the history

  8. add comment about how readRDS does not work with rawConnection

    @schloerke
    schloerke committed Jul 31, 2020
    Copy the full SHA
    0761880 View commit details
    Browse the repository at this point in the history

  9. Forgot to add function in the pseudo docs 

    Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
    @schloerke @cpsievert
    schloerke and cpsievert committed Jul 31, 2020
    Copy the full SHA
    16e01a9 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'post_body_content_type' of https://github.com/rstudio/p… 

    …lumber into post_body_content_type
    @schloerke
    schloerke committed Jul 31, 2020
    Copy the full SHA
    7989213 View commit details
    Browse the repository at this point in the history

  11. Do not export make_parsers(). Copy over appropriate docs

    @schloerke
    schloerke committed Jul 31, 2020
    Copy the full SHA
    6959dd7 View commit details
    Browse the repository at this point in the history

  12. Do not display docs for make_parser()

    @schloerke
    schloerke committed Jul 31, 2020
    Copy the full SHA
    4d8591f View commit details
    Browse the repository at this point in the history

  13. update news entry

    @schloerke
    schloerke committed Jul 31, 2020
    Copy the full SHA
    7be4fec View commit details
    Browse the repository at this point in the history