Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker files #589

Merged
merged 16 commits into from Jul 24, 2020
Merged

Update Docker files #589

merged 16 commits into from Jul 24, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Jul 9, 2020

Fixes #511
Fixes #425
Fixes #457
Fixes #459

  • Adds Docker images to https://hub.docker.com/r/rstudio/plumber
  • Builds tags for
    • v0.4.6, latest for the plumber@v0.4.6
    • (As new releases are made, all stable releases should be maintained for a reasonable amount of time.)
    • next for master branch
  • Reverses command line arguments to retrieve file which avoids issue when extra arguments are provided

@schloerke schloerke added this to the v0.5.0 - Next CRAN release milestone Jul 9, 2020
@schloerke schloerke requested a review from cpsievert Jul 9, 2020
@schloerke schloerke changed the title Reverse command args to always get the last arg Update Docker files Jul 13, 2020
@schloerke
Copy link
Collaborator Author

schloerke commented Jul 13, 2020

@mskyttner and @MarkEdmondson1234 . Would these updates work for you? Would you like to see any more changes?

@MarkEdmondson1234
Copy link

MarkEdmondson1234 commented Jul 13, 2020

Looks great thanks!

Docker/GitHub/Dockerfile Outdated Show resolved Hide resolved
Docker/GitHub/Dockerfile Outdated Show resolved Hide resolved
Docker/CRAN/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/docker.yaml Outdated Show resolved Hide resolved
.github/workflows/docker.yaml Outdated Show resolved Hide resolved
@cpsievert cpsievert self-requested a review Jul 13, 2020
Copy link
Contributor

@cpsievert cpsievert left a comment

LGTM after suggestions

@schloerke schloerke added the QA Submitted for QA label Jul 20, 2020
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@schloerke schloerke merged commit 20427b1 into master Jul 24, 2020
15 of 16 checks passed
@schloerke schloerke deleted the docker/command_args_order branch Jul 24, 2020
schloerke added a commit that referenced this pull request Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Submitted for QA
Projects
None yet
3 participants