Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace plus sign with space character when parsing a query string #618

Merged
merged 3 commits into from Jul 27, 2020

Conversation

meztez
Copy link
Collaborator

@meztez meztez commented Jul 24, 2020

plumber:::parseQS("?a=2&a=3&c=&&d=et+te")

Fixes #617

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

@schloerke schloerke requested a review from wch Jul 24, 2020
Copy link
Collaborator

@schloerke schloerke left a comment

LGTM! (given suggestion)

Co-authored-by: Barret Schloerke <barret@rstudio.com>
@schloerke schloerke changed the title plus sign replacement with space character Replace plus sign with space character when parsing a query string Jul 27, 2020
@schloerke schloerke merged commit 07672ce into rstudio:master Jul 27, 2020
15 of 16 checks passed
schloerke added a commit that referenced this pull request Jul 28, 2020
* master:
  Replace plus sign with space character when parsing a query string (#618)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space encoding in the GET input query parameter (+ vs %20)
2 participants