Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Add release tag to r2d3 #31

Closed
amandamasonsingh opened this issue May 17, 2018 · 6 comments
Closed

Request: Add release tag to r2d3 #31

amandamasonsingh opened this issue May 17, 2018 · 6 comments

Comments

@amandamasonsingh
Copy link

I would like to make a conda package for the r2d3 package.

According to this issue on GitHub, the repo of interest, r2d3 in this case, must have at least one release tag.

Here is the output of conda skeleton cran https://github.com/rstudio/r2d3:

conda skeleton cran https://github.com/rstudio/r2d3

Tip: install CacheControl and lockfile (conda packages) to cache the CRAN metadata
Fetching metadata from https://cran.r-project.org/
Parsing input package https://github.com/rstudio/r2d3:
.. name: r2d3 location: https://github.com/rstudio/r2d3 new_location: /Users/amasonsingh/r-r2d3
Making/refreshing recipe for r2d3
Cloning into '/anaconda3/conda-bld/skeleton_1526498646711/work'...
done.
checkout: 'HEAD'
Your branch is up to date with 'origin/_conda_cache_origin_head'.
==> git log -n1 <==

fatal: No names found, cannot describe anything.
commit 0f4f58ab92869bb525cef4a31e0d5a78bd028e88
Author: jjallaire <jj@rstudio.com>
Date:   Wed May 16 07:48:51 2018 -0400

    remove sourceMappingURL for webcomponents-bundle.js

==> git describe --tags --dirty <==

commit 0f4f58ab92869bb525cef4a31e0d5a78bd028e88
Author: jjallaire <jj@rstudio.com>
Date:   Wed May 16 07:48:51 2018 -0400

    remove sourceMappingURL for webcomponents-bundle.js

==> git status <==

On branch _conda_cache_origin_head
Your branch is up to date with 'origin/_conda_cache_origin_head'.

nothing to commit, working tree clean


Leaving build/test directories:
  Work:	 /anaconda3/conda-bld/skeleton_1526498646711/work 
  Test:	 /anaconda3/conda-bld/skeleton_1526498646711/test_tmp 
Leaving build/test environments:
  Test:	source activate  /anaconda3/conda-bld/skeleton_1526498646711/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p 
  Build:	source activate  /anaconda3/conda-bld/skeleton_1526498646711/_build_env 


Error: no tags found
@javierluraschi
Copy link
Contributor

@amandamasonsingh
Copy link
Author

Fantastic! Thank you @javierluraschi!

Also - I have this version of the package up on Anaconda cloud if it is helpful to anyone using conda:

anaconda download amandamasonsingh/r-r2d3

@javierluraschi
Copy link
Contributor

@amandamasonsingh not sure how easy it is to update the anaconda release, but we made a couple tweaks to the v0.2.0 release tag, will they be automatically picked? Otherwise, the anaconda release would be missing minified JS files and avoid console errors on really old browsers, not deal breakers but would be nice to keep in sync CRAN and Anaconda releases.

@amandamasonsingh
Copy link
Author

amandamasonsingh commented May 30, 2018

@javierluraschi - it's fairly easy to update the anaconda package - but it does require a manual update each time. Since I have the anaconda package on my anaconda cloud account, that means that I would need to update it each time. I certainly am ok with updating the package whenever I need to use it, but I might not be as prompt in updating as someone who is closer to the project.

If your team would rather host this on your own anaconda cloud account then that's fine - OR see if anaconda can host it as one of their r-essentials packages. In such case, I think they might keep it up-to-date?

Here is a tutorial on how to build a conda package using conda skeleton: https://conda.io/docs/user-guide/tutorials/build-pkgs-skeleton.html
(in this case, we need conda skeleton cran https://github.com/rstudio/r2d3. Note also that you have to build a package for the htmlwidgets as well first, which I also have hosted on my anaconda cloud account anaconda download amandamasonsingh/r-htmlwidgets)

(Also note: If anyone needs an updated version to use at any time, they can always build their own conda package using the steps described above with the conda skeleton cran https://github.com/rstudio/r2d3 command.)

@javierluraschi
Copy link
Contributor

Hi @amandamasonsingh, I don't have enough bandwidth to also maintain the anaconda packages, so feel free to update this package in anaconda as your time permits. I just wanted to point out that there are new release tags that you might want to consider porting to the anaconda repo.

@amandamasonsingh
Copy link
Author

amandamasonsingh commented May 30, 2018

@javierluraschi - Sure, sounds like a plan! I will regularly check back in whenever I am using the r2d3 package and will update it on my anaconda cloud account when I do so.

Thanks!

(UPDATE: The anaconda cloud version of the package r-r2d3 is updated to v0.2.2 as of May 30th, 2018 - the install instructions above are valid for installing this version.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants