handle repositories without binary arms (closes #1045)

rstudio · Jul 18, 2022 · a0f34e3 · a0f34e3
1 parent ccc67d7
commit a0f34e3
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: renv
 Type: Package
 Title: Project Environments
-Version: 0.15.5-39
+Version: 0.15.5-40
 Authors@R: c(
     person("Kevin", "Ushey", role = c("aut", "cre"), email = "kevin@rstudio.com"),
     person("RStudio, PBC", role = c("cph"))

diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,11 @@
 
 # renv 0.16.0  (UNRELEASED)
 
+* Fixed an issue where package installation could fail when the R session
+  is configured to use multiple repositories, some of which do not provide
+  any information on available packages for certain binary arms of the
+  repository. (#1045)
+
 * `renv` now uses `jsonlite` for reading lockfiles when loaded. This should
   help ensure useful errors are provided for manually-edited lockfiles
   which contain a JSON parsing error. If the `jsonlite` package is not loaded,

diff --git a/R/available-packages.R b/R/available-packages.R
@@ -346,8 +346,15 @@ renv_available_packages_latest_repos_impl <- function(package, type, repos) {
   version <- numeric_version(entries$Version)
   ordered <- order(version, decreasing = TRUE)
 
-  # return newest-available version
+  # extract newest entry
   entry <- as.list(entries[ordered[[1L]], ])
+
+  # remove an NA file entry if necessary
+  # https://github.com/rstudio/renv/issues/1045
+  if (length(entry$File) && is.na(entry$File))
+    entry$File <- NULL
+
+  # return newest-available version
   renv_available_packages_record(entry, type)
 
 }